From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH v2] http: add custom hostname to IP address resolutions
Date: Thu, 5 May 2022 04:21:14 -0700 [thread overview]
Message-ID: <20220505112114.ktki3dgjbyukzhlm@carlos-mbp.lan> (raw)
In-Reply-To: <20220504104601.136403-1-chriscool@tuxfamily.org>
On Wed, May 04, 2022 at 12:46:01PM +0200, Christian Couder wrote:
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index f92c79c132..d97380be87 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -567,4 +567,11 @@ test_expect_success 'client falls back from v2 to v0 to match server' '
> grep symref=HEAD:refs/heads/ trace
> '
>
> +test_expect_success 'passing hostname resolution information works' '
> + BOGUS_HOST=gitbogusexamplehost.com &&
minor nitpick, but better to use example.com here which is reserved for this
type of uses and therefore unlikely to conflict with a possibly assigned
domain.
Carlo
next prev parent reply other threads:[~2022-05-05 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 8:36 [PATCH] http: add custom hostname to IP address resolves Christian Couder
2022-05-02 19:04 ` Junio C Hamano
2022-05-04 10:07 ` Christian Couder
2022-05-04 14:34 ` Junio C Hamano
2022-05-05 10:48 ` Christian Couder
2022-05-05 11:16 ` Carlo Marcelo Arenas Belón
2022-05-09 15:40 ` Christian Couder
2022-05-04 10:46 ` [PATCH v2] http: add custom hostname to IP address resolutions Christian Couder
2022-05-05 11:21 ` Carlo Marcelo Arenas Belón [this message]
2022-05-12 8:52 ` Christian Couder
2022-05-12 16:22 ` Junio C Hamano
2022-05-12 18:57 ` Christian Couder
2022-05-09 15:38 ` [PATCH v3] " Christian Couder
2022-05-10 18:20 ` Carlo Arenas
2022-05-12 8:29 ` Christian Couder
2022-05-12 11:55 ` Carlo Arenas
2022-05-12 13:01 ` Patrick Steinhardt
2022-05-12 13:56 ` Carlo Arenas
2022-05-12 15:58 ` Junio C Hamano
2022-05-16 8:38 ` [PATCH v4] " Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505112114.ktki3dgjbyukzhlm@carlos-mbp.lan \
--to=carenas@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).