git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Øystein Walle" <oystwa@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, mail@rkta.de, oystwa@gmail.com
Subject: Re: [PATCH 1/2] blame: Make --show-name negatable
Date: Tue, 13 Sep 2022 10:56:31 +0200	[thread overview]
Message-ID: <20220913085631.4031-1-walle@fryseskap.localdomain> (raw)
In-Reply-To: <xmqqsfkwftd0.fsf@gitster.g>

Hi, Junio

> Not clear to this bystander what exactly is going on.  Is the patch
> Rene relayed is your rough attempt that was incomplete?

Correct! I am the nice IRC that was mentioned in the cover letter. My
improved patch is the one in the e-mail you responded to, apart from
GMail's text wrapping that was unaware of until now.

> Thanks.  Let's see if we can have an cleaned-up version with tests,
> then.

I can send a corrected (and correctly formatted patch) for review,
optionally with the docs squashed in with Rene's permission. Maybe Rene
would like to take a stab at writing tests? I am in the process of
moving house and my usual workstation is not exactly online, so it'll be
a while.

Øsse

  reply	other threads:[~2022-09-13  8:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12  5:45 [PATCH 0/2] blame: Make --show-name negatable Rene Kita
2022-09-12  5:45 ` [PATCH 1/2] " Rene Kita
2022-09-12 13:25   ` Øystein Walle
2022-09-12 16:30     ` Junio C Hamano
2022-09-13  8:56       ` Øystein Walle [this message]
2022-09-13  9:08         ` Rene Kita
2022-09-12  5:45 ` [PATCH 2/2] blame: Document that --show-name is negatable Rene Kita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220913085631.4031-1-walle@fryseskap.localdomain \
    --to=oystwa@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mail@rkta.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).