From: Kostya Farber <kostya.farber@gmail.com>
To: git@vger.kernel.org
Cc: Kostya Farber <kostya.farber@gmail.com>
Subject: [GSoC][PATCH] t/t5000-tar-tree: add helper function
Date: Thu, 2 Feb 2023 20:25:57 +0000 [thread overview]
Message-ID: <20230202202557.19297-1-kostya.farber@gmail.com> (raw)
Add the helper function test_file_path_exists to the
interpret pax header test. This change makes it clearer
as to what the test is trying to check, in this case whether
a file path exists.
Signed-off-by: Kostya Farber <kostya.farber@gmail.com>
---
Hello all. I'd like to introduce myself. My name is
Kostya, I am new to the git open source community.
I am a data engineer by trade, but have recently gotten
into (and am really enjoying) the open source world.
My main contributions have been in the scientific
python space (https://github.com/kostyafarber).
I have read MyFirstContribution, documentation in
t/README and the general GSoC page. I have really
started to enjoy low-level programming and have
been going through The C Programming Language (Second
Edition) and the Linux Programming Interface.
I am planning to submit a proposal for GSoC (hopefully) and
want to try help out and contribute to a tool I've been using
for a long time and have love for.
Keen to speak to you all soon.
t/t5000-tar-tree.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index d473048138..19d5bd0c04 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -73,7 +73,7 @@ check_tar() {
for header in *.paxheader
do
data=${header%.paxheader}.data &&
- if test -h $data || test -e $data
+ if test -h $data || test_file_path_exists $data
then
path=$(get_pax_header $header path) &&
if test -n "$path"
--
2.39.0
next reply other threads:[~2023-02-02 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 20:25 Kostya Farber [this message]
2023-02-02 22:36 ` [GSoC][PATCH] t/t5000-tar-tree: add helper function Junio C Hamano
2023-02-02 23:09 ` Eric Sunshine
2023-02-02 23:19 ` Eric Sunshine
2023-02-04 15:16 ` Kostya Farber
2023-02-05 17:59 ` Eric Sunshine
2023-02-04 15:12 ` Kostya Farber
2023-02-04 15:04 ` Kostya Farber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202202557.19297-1-kostya.farber@gmail.com \
--to=kostya.farber@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).