From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Linus Arver <linusa@google.com>,
jacobabel@nullpo.dev
Subject: Re: [PATCH v4] MyFirstContribution: refrain from self-iterating too much
Date: Fri, 28 Jul 2023 23:21:44 +0200 [thread overview]
Message-ID: <20230728212144.dpcbp6gfhfuiabia@tb-raspi4> (raw)
In-Reply-To: <xmqqmszg987u.fsf_-_@gitster.g>
On Thu, Jul 27, 2023 at 05:43:17PM -0700, Junio C Hamano wrote:
> Finding mistakes in and improving your own patches is a good idea,
> but doing so too quickly is being inconsiderate to reviewers who
> have just seen the initial iteration and taking their time to review
> it. Encourage new developers to perform such a self review before
> they send out their patches, not after. After sending a patch that
> they immediately found mistakes in, they are welcome to comment on
> them, mentioning what and how they plan to improve them in an
> updated version, before sending out their updates.
That's all good, no possible improvements from my side.
However, a possible question below.
[]
> +Please give reviewers enough time to process your initial patch before
> +sending an updated version. That is, resist the temptation to send a new
> +version immediately, because others may have already started reviewing
> +your initial version.
> +
> +While waiting for review comments, you may find mistakes in your initial
> +patch, or perhaps realize a different and better way to achieve the goal
> +of the patch. In this case you may communicate your findings to other
> +reviewers as follows:
> +
> + - If the mistakes you found are minor, send a reply to your patch as if
> + you were a reviewer and mention that you will fix them in an
> + updated version.
> +
> + - On the other hand, if you think you want to change the course so
> + drastically that reviews on the initial patch would be a waste of
> + time (for everyone involved), retract the patch immediately with
> + a reply like "I am working on a much better approach, so please
> + ignore this patch and wait for the updated version."
> +
(That's all good)
> +Now, the above is a good practice if you sent your initial patch
> +prematurely without polish. But a better approach of course is to avoid
> +sending your patch prematurely in the first place.
That is of course a good suggestion.
I wonder, how much a first time contributor knows about "polishing",
in the Git sense ?
From my experience, the polishing is or could be a learning process,
which needs interaction with the reviewers.
Would it make sense to remove the sentences above and ask people
to mark their patch with RFC ?
Or is this all too much bikeshedding, IOW I am happy with V4 as is.
next prev parent reply other threads:[~2023-07-28 21:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 1:51 [PATCH] MyFirstContribution: refrain from self-iterating too much Junio C Hamano
2023-01-22 7:11 ` Torsten Bögershausen
2023-01-22 16:01 ` Junio C Hamano
2023-01-22 17:14 ` Junio C Hamano
2023-01-23 4:18 ` [PATCH v2] " Junio C Hamano
2023-01-23 17:58 ` Torsten Bögershausen
2023-07-19 17:04 ` [PATCH v3] " Junio C Hamano
2023-07-27 23:14 ` Linus Arver
2023-07-28 0:25 ` Junio C Hamano
2023-07-28 0:43 ` [PATCH v4] " Junio C Hamano
2023-07-28 2:07 ` Jacob Abel
2023-07-28 5:10 ` Junio C Hamano
2023-07-28 15:42 ` Re* " Junio C Hamano
2023-07-29 2:12 ` Jacob Abel
2023-07-31 15:25 ` Junio C Hamano
2023-07-28 2:08 ` Linus Arver
2023-07-28 5:10 ` Junio C Hamano
2023-07-28 21:21 ` Torsten Bögershausen [this message]
2023-07-28 23:00 ` Junio C Hamano
2023-01-23 1:47 ` [PATCH] " Sean Allred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728212144.dpcbp6gfhfuiabia@tb-raspi4 \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacobabel@nullpo.dev \
--cc=linusa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).