git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Drew DeVault <sir@cmpwn.com>, git@vger.kernel.org
Subject: Re: [PATCH v4] format-patch: --rfc honors what --subject-prefix sets
Date: Thu, 31 Aug 2023 18:32:01 -0400	[thread overview]
Message-ID: <20230831223201.GB952036@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqv8cuswah.fsf@gitster.g>

On Thu, Aug 31, 2023 at 03:04:54PM -0700, Junio C Hamano wrote:

> Sure.  FWIW, I like giving a meaningful name to a thing that is used
> more than once, so my preference is the original minus excess cast.
> 
> Thanks for a review.  Here is a tentative rewrite

Thanks, looks good to me.

-Peff

  reply	other threads:[~2023-08-31 22:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  6:43 [PATCH v4] format-patch: --rfc honors what --subject-prefix sets Drew DeVault
2023-08-30 19:28 ` Junio C Hamano
2023-08-31 21:29   ` Jeff King
2023-08-31 22:04     ` Junio C Hamano
2023-08-31 22:32       ` Jeff King [this message]
2023-09-01  7:29       ` Drew DeVault
2023-09-01 16:48         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831223201.GB952036@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sir@cmpwn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).