From: Jeff King <peff@peff.net>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/4] mark tests as leak-free
Date: Tue, 30 Jan 2024 00:54:48 -0500 [thread overview]
Message-ID: <20240130055448.GC166761@coredump.intra.peff.net> (raw)
In-Reply-To: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com>
On Mon, Jan 29, 2024 at 10:04:10PM +0100, Rubén Justo wrote:
> The tests: t0080, t5332 and t6113 can be annotated as leak-free.
>
> I used:
> $ make SANITIZE=leak GIT_TEST_PASSING_SANITIZE_LEAK=check GIT_TEST_SANITIZE_LEAK_LOG=true test
>
> Rubén Justo (4):
> t0080: mark as leak-free
> t5332: mark as leak-free
> t6113: mark as leak-free
> test-lib: check for TEST_PASSES_SANITIZE_LEAK
These all looked reasonable to me. Thank you for not just fixing them,
but including the background for each case (e.g., leak-free as of commit
XYZ, etc).
-Peff
next prev parent reply other threads:[~2024-01-30 5:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 21:04 [PATCH 0/4] mark tests as leak-free Rubén Justo
2024-01-29 21:08 ` [PATCH 1/4] t0080: mark " Rubén Justo
2024-01-29 22:15 ` Junio C Hamano
2024-01-29 23:20 ` Rubén Justo
2024-01-29 23:51 ` Junio C Hamano
2024-01-30 18:14 ` Rubén Justo
2024-01-30 5:53 ` Jeff King
2024-01-30 20:00 ` Junio C Hamano
2024-01-29 21:08 ` [PATCH 2/4] t5332: " Rubén Justo
2024-01-29 21:08 ` [PATCH 3/4] t6113: " Rubén Justo
2024-01-29 21:08 ` [PATCH 4/4] test-lib: check for TEST_PASSES_SANITIZE_LEAK Rubén Justo
2024-01-29 22:25 ` Junio C Hamano
2024-01-30 5:54 ` Jeff King [this message]
2024-01-30 16:01 ` [PATCH 0/4] mark tests as leak-free Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130055448.GC166761@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).