From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/4] some v2 capability advertisement cleanups
Date: Wed, 28 Feb 2024 17:46:25 -0500 [thread overview]
Message-ID: <20240228224625.GA1158651@coredump.intra.peff.net> (raw)
While working on another series, I noticed that upload-pack will accept
the "packfile-uris" directive even if we didn't advertise it. That's not
a huge deal in practice, but the spec says we're not supposed to. And
while cleaning that up, I noticed a bit of duplication in the existing
advertisement/allow code.
So patches 1-3 clean up the situation a bit, and then patch 4 tightens
up the packfile-uris handling.
There are some small textual conflicts with the series I just posted in:
https://lore.kernel.org/git/20240228223700.GA1157826@coredump.intra.peff.net/
I'm happy to prepare this on top of that if it's easier.
[1/4]: upload-pack: use repository struct to get config
[2/4]: upload-pack: centralize setup of sideband-all config
[3/4]: upload-pack: use existing config mechanism for advertisement
[4/4]: upload-pack: only accept packfile-uris if we advertised it
t/t5702-protocol-v2.sh | 18 +++++++++++++
upload-pack.c | 58 +++++++++++++++++++-----------------------
2 files changed, 44 insertions(+), 32 deletions(-)
-Peff
next reply other threads:[~2024-02-28 22:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 22:46 Jeff King [this message]
2024-02-28 22:46 ` [PATCH 1/4] upload-pack: use repository struct to get config Jeff King
2024-03-04 7:45 ` Patrick Steinhardt
2024-02-28 22:47 ` [PATCH 2/4] upload-pack: centralize setup of sideband-all config Jeff King
2024-02-28 22:48 ` [PATCH 3/4] upload-pack: use existing config mechanism for advertisement Jeff King
2024-02-28 22:50 ` [PATCH 4/4] upload-pack: only accept packfile-uris if we advertised it Jeff King
2024-02-28 23:43 ` Junio C Hamano
2024-02-29 5:42 ` Jeff King
2024-02-29 16:34 ` Junio C Hamano
2024-03-01 7:10 ` Jeff King
2024-03-04 7:45 ` Patrick Steinhardt
2024-02-28 23:51 ` [PATCH 0/4] some v2 capability advertisement cleanups Junio C Hamano
2024-02-29 0:44 ` Jeff King
2024-03-04 7:44 ` Patrick Steinhardt
2024-03-04 10:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228224625.GA1158651@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).