From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3386C433EF for ; Tue, 29 Mar 2022 12:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236211AbiC2MFz (ORCPT ); Tue, 29 Mar 2022 08:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236213AbiC2MFw (ORCPT ); Tue, 29 Mar 2022 08:05:52 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE1DC2C65D for ; Tue, 29 Mar 2022 05:04:08 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id z92so20408118ede.13 for ; Tue, 29 Mar 2022 05:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=yTfEHsOBjrzNiNI9DQA4fAcYOp1UxccuR4Os8y0HSx4=; b=ce9V/lEoN2v0O+8HyoBdQ6SlskBCwOK/R9fX2XpIMPS1H4Cr2apqT/tF8zjw8/tnCp +HawQ502o2cNFyoxFPKekAQeMIXJnEaGjmzwCKubr9v1vf36SjWZnsZ4uyUPwBI0Fm/y MjCryfd/VRdkKVX3DgIE6yRkMUt8j1oHuJGL0qeJogya9sLDUdtO5AXxsecv9mxvF81N YCUsIRbcrmmoDPPQnXxjadZZSWc9h8A6uYDBh6O3df3fRYMWBqTb8EdpjPzIZKaOfo+I fNIO6uaQuK1PnVdYdciBCcPeDuX2f6gJKyJT0YZTqC5AyvsDedAlJndGLbWcoS7noxhO CzaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=yTfEHsOBjrzNiNI9DQA4fAcYOp1UxccuR4Os8y0HSx4=; b=FcqurjafkBZDv3lqEdKMekIszxp0f/WO/XqOmbRR63pUpzXmj3tjMLPc3m0iiRat1j eWb/3ZYX8lmJt1aOim5WlBvYsDaio8d9LvR+4/OjfzppkTXB1pdDSO/pvsWmSDc8XQPR 2dea1yUkAWcjYQCul7b9nLPcj+6rcUsdoCKpTtuhZqYPrfAwh3rHD7Tg5U2StoufaGLk Yl7KY29Ot1mtAyJcaSX3B6NbOi61qnjWCRasi6qxuMwjbc0PpUVclHXj0NmX45Hhp3he hIi63dNAomZsVsoAGqs7BrC3f9MZh+uK1JJuL0UNIwm72B0xdYWFG5090MQyFF0mUSXH GlZQ== X-Gm-Message-State: AOAM532bZKllZD3tfGKpufeD9hUyiXOEw9mAfhhUxIQdjl+2HqNkpAzX Ped1dVS6k+HAz4aLMmH/HaKf3D3ODULYwA== X-Google-Smtp-Source: ABdhPJzSSrae6rXt++eDq+vQb76Bwt8RXrfcFDfTaLdUzracIYAt9bD1PUZHFdJbgqnw5D3K23Y+lg== X-Received: by 2002:a05:6402:3689:b0:419:d380:ddbc with SMTP id ej9-20020a056402368900b00419d380ddbcmr4106155edb.230.1648555446623; Tue, 29 Mar 2022 05:04:06 -0700 (PDT) Received: from gmgdl (j120189.upc-j.chello.nl. [24.132.120.189]) by smtp.gmail.com with ESMTPSA id p10-20020a17090664ca00b006df8869d58dsm7018868ejn.100.2022.03.29.05.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 05:04:05 -0700 (PDT) Received: from avar by gmgdl with local (Exim 4.95) (envelope-from ) id 1nZAZx-003cpT-A6; Tue, 29 Mar 2022 14:04:05 +0200 From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: "Neeraj K. Singh via GitGitGadget" Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de, nksingh85@gmail.com, ps@pks.im, jeffhost@microsoft.com, Bagas Sanjaya , worldhello.net@gmail.com, "Neeraj K. Singh" Subject: Re: [PATCH v4 00/13] core.fsyncmethod: add 'batch' mode for faster fsyncing of multiple objects Date: Tue, 29 Mar 2022 13:45:17 +0200 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.11 In-reply-to: Message-ID: <220329.868rst2cei.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Mar 29 2022, Neeraj K. Singh via GitGitGadget wrote: > V4 changes: > > * Make ODB transactions nestable. > * Add an ODB transaction around writing out the cached tree. > * Change update-index to use a more straightforward way of managing ODB > transactions. > * Fix missing 'local's in lib-unique-files > * Add a per-iteration setup mechanism to test_perf. > * Fix camelCasing in warning message. Despite my https://lore.kernel.org/git/220329.86czi52ekn.gmgdl@evledraar.gmail.com/ I eventually gave up on trying to extract meaningful numbers from t/perf, I can never quite find out if they're because of its shellscripts shenanigans or actual code. (And also; I realize I didn't follow-up on https://lore.kernel.org/git/CANQDOdcFN5GgOPZ3hqCsjHDTiRfRpqoAKxjF1n9D6S8oD9= --_A@mail.gmail.com/, sorry): But I came up with this (uses my thin https://gitlab.com/avar/git-hyperfine/ wrapper, and you should be able to apt get hyperfine): =09 #!/bin/sh set -xe =09 if ! test -d /tmp/scalar.git then git clone --bare https://github.com/Microsoft/scalar.git /tmp/scalar.git mv /tmp/scalar.git/objects/pack/*.pack /tmp/scalar.git/my.pack fi git hyperfine \ --warmup 1 -r 3 \ -L rev neeraj-v4,avar-RFC \ -s 'make CFLAGS=3D-O3 && rm -rf repo && git init repo && cp -R t repo/ &&= git ls-files -- t >repo/.git/to-add.txt' \ -p 'rm -rf repo/.git/objects/* repo/.git/index' \ $@'./git -c core.fsync=3Dloose-object -c core.fsyncMethod=3Dbatch -C repo= update-index --add --stdin repo/.git/to-add.txt -p rm -rf repo/.git/objects/* repo/.git/index ./git= -c core.fsync=3Dloose-object -c core.fsyncMethod=3Dbatch -C repo update-in= dex --add --stdin