From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Tao Klerks via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Tao Klerks <tao@klerks.biz>
Subject: Re: [PATCH v2] [RFC] git-p4: improve encoding handling to support inconsistent encodings
Date: Wed, 13 Apr 2022 15:59:45 +0200 [thread overview]
Message-ID: <220413.86zgkpf5g7.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1206.v2.git.1649831069578.gitgitgadget@gmail.com>
On Wed, Apr 13 2022, Tao Klerks via GitGitGadget wrote:
> Under python2, git-p4 "naively" writes the Perforce bytestream into git
> metadata (and does not set an "encoding" header on the commits); this
> means that any non-utf-8 byte sequences end up creating invalidly-encoded
> commit metadata in git.
If it doesn't have an "encoding" header isn't any sequence of bytes OK
with git, so how does it create invalid metadata in git?
Do you mean that something on the Python side gets confused and doesn't
correctly encode it in that case, or that it's e.g. valid UTF-8 but
we're lacking the metadata?
next prev parent reply other threads:[~2022-04-13 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 9:42 [PATCH] [RFC] git-p4: improve encoding handling to support inconsistent encodings Tao Klerks via GitGitGadget
2022-04-13 6:24 ` [PATCH v2] " Tao Klerks via GitGitGadget
2022-04-13 13:59 ` Ævar Arnfjörð Bjarmason [this message]
2022-04-13 15:18 ` Tao Klerks
2022-04-13 18:52 ` Ævar Arnfjörð Bjarmason
2022-04-14 9:38 ` Tao Klerks
2022-04-13 20:41 ` Andrew Oakley
2022-04-14 9:57 ` Tao Klerks
2022-04-17 18:11 ` Andrew Oakley
2022-04-19 20:30 ` Tao Klerks
2022-04-19 20:19 ` [PATCH v3] " Tao Klerks via GitGitGadget
2022-04-19 20:33 ` Tao Klerks
2022-04-30 19:26 ` [PATCH v4] " Tao Klerks via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220413.86zgkpf5g7.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).