git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Alyssa Ross <hi@alyssa.is>
Subject: ar/send-email-confirm-by-default (was: What's cooking in git.git (May 2022, #05; Mon, 16))
Date: Thu, 19 May 2022 21:34:31 +0200	[thread overview]
Message-ID: <220519.86o7zt2u1g.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq5ym4zpmn.fsf@gitster.g>


On Mon, May 16 2022, Junio C Hamano wrote:

> * ar/send-email-confirm-by-default (2022-04-22) 1 commit
>  - send-email: always confirm by default
>
>  "git send-email" is changed so that by default it asks for
>  confirmation before sending each message out.
>
>  Will discard.
>
>  I wanted to like this, and had it in the version of Git I use
>  myself for daily work, but the prompting turned out to be somewhat
>  distracting.
>
>  Thoughts?
>  source: <20220422083629.1404989-1-hi@alyssa.is>

I'd prefer for this to go in. As noted in my review I've been running
with this setting for many years, and I don't think I'd trust myself to
use git-send-email without it.

But it's always hard to figure out what's the right UX trade-off in
these cases, particularly for something like git-send-email which is a
relatively advanced tool, and likely has a small-ish userbase that's
used to the current defaults.

But for those users setting the config to the current (and more
foot-gun-y) will be easy, and I think making this friendlier to
newcomers is worth it.

      parent reply	other threads:[~2022-05-19 19:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  5:37 What's cooking in git.git (May 2022, #05; Mon, 16) Junio C Hamano
2022-05-17 13:10 ` Derrick Stolee
2022-05-20 23:28   ` Taylor Blau
2022-05-19 15:23 ` Carlo Marcelo Arenas Belón
2022-05-19 17:29   ` Junio C Hamano
2022-05-19 19:28 ` ab/env-array (was: What's cooking in git.git (May 2022, #05; Mon, 16)) Ævar Arnfjörð Bjarmason
2022-05-19 21:41   ` ab/env-array Junio C Hamano
2022-05-20  8:33     ` ab/env-array Ævar Arnfjörð Bjarmason
2022-05-19 19:34 ` Ævar Arnfjörð Bjarmason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220519.86o7zt2u1g.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).