From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Phillip Wood <phillip.wood123@gmail.com>,
Calvin Wan <calvinwan@google.com>,
Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310
Date: Mon, 31 Oct 2022 13:44:44 +0100 [thread overview]
Message-ID: <221031.86tu3k6u2d.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <Y12I7zSohPu2cyJt@nand.local>
On Sat, Oct 29 2022, Taylor Blau wrote:
> [+cc Emily]
>
> On Sat, Oct 29, 2022 at 04:59:45AM +0200, Ævar Arnfjörð Bjarmason wrote:
>> diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
>> index 43fcb7c0bfc..2ef3579fa7c 100755
>> --- a/t/t1800-hook.sh
>> +++ b/t/t1800-hook.sh
>> @@ -95,7 +95,7 @@ test_expect_success 'git hook run -- out-of-repo runs excluded' '
>> test_expect_success 'git -c core.hooksPath=<PATH> hook run' '
>> mkdir my-hooks &&
>> write_script my-hooks/test-hook <<-\EOF &&
>> - echo Hook ran $1 >>actual
>> + echo Hook ran $1
>> EOF
>
> Looking reasonable to me. Though let's see what Emily thinks, too...
FWIW Junio looked at it back in
https://lore.kernel.org/git/xmqqczh84fpy.fsf@gitster.g/
next prev parent reply other threads:[~2022-10-31 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 2:59 [PATCH 0/3] tests: improve misc run-command, hook, submodule tests Ævar Arnfjörð Bjarmason
2022-10-29 2:59 ` [PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310 Ævar Arnfjörð Bjarmason
2022-10-29 20:11 ` Taylor Blau
2022-10-31 12:44 ` Ævar Arnfjörð Bjarmason [this message]
2022-10-31 23:56 ` Taylor Blau
2022-10-29 2:59 ` [PATCH 2/3] submodule tests: reset "trace.out" between "grep" invocations Ævar Arnfjörð Bjarmason
2022-10-29 20:13 ` Taylor Blau
2022-10-31 12:50 ` Ævar Arnfjörð Bjarmason
2022-10-31 23:58 ` Taylor Blau
2022-10-29 2:59 ` [PATCH 3/3] run-command tests: test stdout of run_command_parallel() Ævar Arnfjörð Bjarmason
2022-10-29 20:15 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221031.86tu3k6u2d.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=calvinwan@google.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).