git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: William Sprent via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, William Sprent <williams@unity3d.com>
Subject: Re: [PATCH] dir: check for single file cone patterns
Date: Tue, 20 Dec 2022 15:33:51 +0100	[thread overview]
Message-ID: <221220.86sfhaw3c3.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1446.git.1671546459151.gitgitgadget@gmail.com>


On Tue, Dec 20 2022, William Sprent via GitGitGadget wrote:

> From: William Sprent <williams@unity3d.com>
> [...]
> +	if (!(given->flags & PATTERN_FLAG_MUSTBEDIR) &&
> +	    !!strcmp(given->pattern, "/*")) {

Style: We use !! to convert 123 to 1 or whatever, but here we just care
about "not matched", so we can drop this !!strcmp() for strcmp().

  reply	other threads:[~2022-12-20 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 14:27 [PATCH] dir: check for single file cone patterns William Sprent via GitGitGadget
2022-12-20 14:33 ` Ævar Arnfjörð Bjarmason [this message]
2022-12-21 12:51   ` William Sprent
2023-01-03  8:20 ` [PATCH v2] " William Sprent via GitGitGadget
2023-01-04  6:07   ` Junio C Hamano
2023-01-04 23:48   ` Victoria Dye
2023-01-05  2:16     ` Junio C Hamano
2023-01-05 11:39     ` William Sprent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=221220.86sfhaw3c3.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=williams@unity3d.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).