From: Philip Oakley <philipoakley@iee.email>
To: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <derrickstolee@github.com>
Cc: git@vger.kernel.org, Elia Pinto <gitter.spiros@gmail.com>
Subject: Re: [PATCH] clone: plug a miniscule leak
Date: Mon, 2 May 2022 21:39:38 +0100 [thread overview]
Message-ID: <225433fb-d5ae-fc92-8d50-03162e75780e@iee.email> (raw)
In-Reply-To: <xmqqzgjzzwnd.fsf@gitster.g>
CC'ing Elia as per the mention. Thread
https://lore.kernel.org/git/xmqqzgjzzwnd.fsf@gitster.g/t/#u.
On 02/05/2022 18:12, Junio C Hamano wrote: <xmqqzgjzzwnd.fsf@gitster.g>
> Derrick Stolee <derrickstolee@github.com> writes:
>
>>> - if (option_origin != NULL)
>> This technically wouldn't hit your rule, since "E" isn't just the
>> variable name, as we typically do with our style. Is that something
>> that Coccinelle automatically simplifies?
>>
>>> + if (option_origin != NULL) {
>> Do you want to take this opportunity to drop the "!= NULL" here?
>>
>>> + free(remote_name);
>>> remote_name = xstrdup(option_origin);
>>> + }
>>>> if (remote_name == NULL)
>> Or do you want to keep similar style from the surrounding code?
> I think that it is better to leave that particular clean-up to
> the equals-null.cocci topic started by Elia; I know having them
> separate would cause a merge conflict, but even if I change them
> here, it will result in the same merge conflict anyway ;-)
prev parent reply other threads:[~2022-05-02 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 5:17 [PATCH] clone: plug a miniscule leak Junio C Hamano
2022-05-02 13:43 ` Derrick Stolee
2022-05-02 17:12 ` Junio C Hamano
2022-05-02 20:39 ` Philip Oakley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225433fb-d5ae-fc92-8d50-03162e75780e@iee.email \
--to=philipoakley@iee.email \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).