From: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, davidk@lysator.liu.se,
Sergei Organov <osv@javad.com>, Kevin Ryde <user42@zip.com.au>
Subject: Re: [PATCH] git-blame.el: Fix compilation warnings.
Date: Thu, 12 Jan 2012 18:08:21 +0100 [thread overview]
Message-ID: <2304907.sEfEeC6Eon@descartes> (raw)
In-Reply-To: <20120112162617.GA2479@burratino>
Hi,
On Thursday 12 January 2012 10:26:41 Jonathan Nieder wrote:
> These lines should be left out [*].
Sorry, I wasn't sure whether to remove them or not. I followed the description
in git-format-patch(1) on how to send patches with kmail. I'll remove them in
the future. Thanks for the advice.
> I assume this was prompted by warning messages like this one:
>
> In git-blame-cleanup:
> git-blame.el:306:6:Warning: `mapcar' called for effect; use `mapc' or
> `dolist' instead
>
> Looks reasonable to my very much untrained eyes, and it's consistent
> with the hints Kevin gave at [1].
Yes. I think the warnings are correct and should be addressed. E.g. Using
mapcar compared to mapc is slower due to the required accumulation of the
results and the additional garbage collection costs. It's not very dramatic
but there is no reason not to fix it imho.
Regards,
Rüdiger
next prev parent reply other threads:[~2012-01-12 17:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 15:44 [PATCH] git-blame.el: Fix compilation warnings Rüdiger Sonderfeld
2012-01-12 16:26 ` Jonathan Nieder
2012-01-12 17:08 ` Rüdiger Sonderfeld [this message]
2012-01-13 23:31 ` Sending patches with KMail (Re: [PATCH] git-blame.el: Fix compilation warnings.) Jonathan Nieder
2012-01-14 0:59 ` Junio C Hamano
2012-01-14 18:31 ` Sending patches with KMail Jonathan Nieder
2012-01-14 18:34 ` Jonathan Nieder
2012-01-15 2:14 ` Junio C Hamano
2012-01-14 19:18 ` Sending patches with KMail (Re: [PATCH] git-blame.el: Fix compilation warnings.) Rüdiger Sonderfeld
2012-06-10 7:38 ` [PATCH] git-blame.el: use mapc instead of mapcar Jonathan Nieder
2012-06-10 11:58 ` [PATCH 1/3] git-blame.el: Do not use goto-line in lisp code Lawrence Mitchell
2012-06-10 11:58 ` [PATCH 2/3] git-blame.el: Use with-current-buffer where appropriate Lawrence Mitchell
2012-06-10 11:58 ` [PATCH 3/3] git-blame.el: Do not use bare 0 to mean (point-min) Lawrence Mitchell
2012-06-14 5:08 ` [PATCH 1/3] git-blame.el: Do not use goto-line in lisp code Jonathan Nieder
2012-06-14 9:14 ` Lawrence Mitchell
2012-06-14 9:37 ` [PATCH v2 " Lawrence Mitchell
2012-06-14 9:37 ` [PATCH v2 2/3] git-blame.el: Use with-current-buffer where appropriate Lawrence Mitchell
2012-06-14 9:38 ` [PATCH v2 3/3] git-blame.el: Do not use bare 0 to mean (point-min) Lawrence Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2304907.sEfEeC6Eon@descartes \
--to=ruediger@c-plusplus.de \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=osv@javad.com \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).