From: Jeff Hostetler <git@jeffhostetler.com>
To: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Josh Steadmon <steadmon@google.com>
Subject: Re: What's cooking in git.git (Dec 2021, #03; Fri, 10)
Date: Mon, 13 Dec 2021 10:32:32 -0500 [thread overview]
Message-ID: <23f0375c-41ab-348f-f11a-161e6514bb9d@jeffhostetler.com> (raw)
In-Reply-To: <xmqqilvvluoa.fsf@gitster.g>
On 12/10/21 9:52 PM, Junio C Hamano wrote:
>
>
> * js/trace2-avoid-recursive-errors (2021-11-18) 1 commit
> (merged to 'next' on 2021-12-02 at c5b1e5ddec)
> + trace2: disable tr2_dst before warning on write errors
>
> trace2 error code path fix.
> source: <5a9e49e7f1540d762374382e1769edf112cf093f.1637272706.git.steadmon@google.com>
Sorry, I've been away from the list for a while.
I just noticed this is using "sigchain_push()" which might
be called from threaded code and could cause problems.
I think pthread_sigmask() would be a safer choice here.
I documented the reasons in compat/simple-ipc/ipc-unix-socket.c
in the header before "thread_block_sigpipe()".
Jeff
next prev parent reply other threads:[~2021-12-13 15:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 2:52 What's cooking in git.git (Dec 2021, #03; Fri, 10) Junio C Hamano
2021-12-11 3:44 ` ns/batched-fsync and ns/remerge-diff Neeraj Singh
2021-12-11 6:38 ` Elijah Newren
2021-12-11 8:39 ` What's cooking in git.git (Dec 2021, #03; Fri, 10) Eric Sunshine
2021-12-13 19:08 ` Junio C Hamano
2021-12-11 10:49 ` Elijah Newren
2021-12-13 18:28 ` Junio C Hamano
2021-12-15 18:47 ` Junio C Hamano
2021-12-11 22:09 ` tb/midx-bitmap-corruption-fix Taylor Blau
2021-12-15 18:47 ` tb/midx-bitmap-corruption-fix Junio C Hamano
2021-12-12 18:37 ` ab/common-main-cleanup (was: What's cooking in git.git (Dec 2021, #03; Fri, 10)) Ævar Arnfjörð Bjarmason
2021-12-12 18:41 ` ab/only-single-progress-at-once " Ævar Arnfjörð Bjarmason
2021-12-13 4:44 ` ab/only-single-progress-at-once Junio C Hamano
2021-12-12 22:42 ` ms/customizable-ident-expansion (was: What's cooking in git.git (Dec 2021, #03; Fri, 10)) Ævar Arnfjörð Bjarmason
2021-12-13 9:02 ` ms/customizable-ident-expansion Junio C Hamano
2021-12-13 15:32 ` Jeff Hostetler [this message]
2021-12-13 15:39 ` What's cooking in git.git (Dec 2021, #03; Fri, 10) Jeff Hostetler
2021-12-14 10:59 ` 'Re: What's cooking in git.git (Dec 2021, #03; Fri, 10)' Teng Long
2021-12-15 18:53 ` Junio C Hamano
2021-12-15 11:10 ` What's cooking in git.git (Dec 2021, #03; Fri, 10) Phillip Wood
2021-12-15 18:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f0375c-41ab-348f-f11a-161e6514bb9d@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).