From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] sequencer: advise if skipping cherry-picked commit
Date: Wed, 18 Aug 2021 11:08:58 +0100 [thread overview]
Message-ID: <2973f162-d2ab-12da-49ec-82ef823089f6@gmail.com> (raw)
In-Reply-To: <xmqqwnotaq0e.fsf@gitster.g>
On 10/08/2021 23:33, Junio C Hamano wrote:
> Josh Steadmon <steadmon@google.com> writes:
>> @@ -5149,8 +5150,13 @@ static int make_script_with_merges(struct pretty_print_context *pp,
>> oidset_insert(&interesting, &commit->object.oid);
>>
>> is_empty = is_original_commit_empty(commit);
>> - if (!is_empty && (commit->object.flags & PATCHSAME))
>> + if (!is_empty && (commit->object.flags & PATCHSAME)) {
>> + advise_if_enabled(ADVICE_SKIPPED_CHERRY_PICKS,
>> + _("skipped previously applied commit %s"),
>> + short_commit_name(commit));
>> + skipped_commit = 1;
>> continue;
>> + }
>> if (is_empty && !keep_empty)
>> continue;
>>
>> @@ -5214,6 +5220,9 @@ static int make_script_with_merges(struct pretty_print_context *pp,
>> oidcpy(&entry->entry.oid, &commit->object.oid);
>> oidmap_put(&commit2todo, entry);
>> }
>> + if (skipped_commit)
>> + advise_if_enabled(ADVICE_SKIPPED_CHERRY_PICKS,
>> + _("use --reapply-cherry-picks to include skipped commits"));
>
> I agree with the change in this hunk that advanced users may want to
> squelch this "what to do" hint.
>
> I am not sure about the earlier hunk that reports when some commits
> have actually been skipped. When --no-reapply-cherry-picks is in
> effect, the user is expecting that some commits are cherry-picks
> among other (hopefully the majority of) commits, and even those
> users who do not want to be taught how to use the command would want
> to learn the fact that some commits were skipped (and which ones).
>
> Using two separate advice configuration variables feel way overkill
> for this. I wonder if the previous hunk should use warning(), i.e.
>
>> + if (!is_empty && (commit->object.flags & PATCHSAME)) {
>> + warning(_("skipped previously applied commit %s"),
>> + short_commit_name(commit));
>> + skipped_commit = 1;
>> continue;
>> + }
>
> possibly squelched by "git rebase --quiet".
I think that would be nicer. Using advise_if_enabled() in the second
hunk makes sense but I think a printing "warning" rather than a "hint"
in the first hunk.
>> @@ -5369,8 +5379,13 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,
>> while ((commit = get_revision(&revs))) {
>> int is_empty = is_original_commit_empty(commit);
>>
>> - if (!is_empty && (commit->object.flags & PATCHSAME))
>> + if (!is_empty && (commit->object.flags & PATCHSAME)) {
>> + advise_if_enabled(ADVICE_SKIPPED_CHERRY_PICKS,
>> + _("skipped previously applied commit %s"),
>> + short_commit_name(commit));
>> + skipped_commit = 1;
>> continue;
>> + }
>
> Likewise. I wonder why we have two so-much-similar codepaths that
> we need to touch, though.
--recreate-merges implemented the main loop for its todo list generation
in a new function as it is much more involved that for the linear case.
Best Wishes
Phillip
>
>> if (is_empty && !keep_empty)
>> continue;
>> strbuf_addf(out, "%s %s ", insn,
>> @@ -5380,6 +5395,9 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,
>> strbuf_addf(out, " %c empty", comment_line_char);
>> strbuf_addch(out, '\n');
>> }
>> + if (skipped_commit)
>> + advise_if_enabled(ADVICE_SKIPPED_CHERRY_PICKS,
>> + _("use --reapply-cherry-picks to include skipped commits"));
>> return 0;
>> }
next prev parent reply other threads:[~2021-08-18 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 20:53 [RFC PATCH] sequencer: warn on skipping previously seen commit Josh Steadmon
2021-08-04 21:28 ` Junio C Hamano
2021-08-05 10:13 ` Phillip Wood
2021-08-05 16:30 ` Junio C Hamano
2021-08-10 19:20 ` [PATCH v2] sequencer: advise if skipping cherry-picked commit Josh Steadmon
2021-08-10 22:33 ` Junio C Hamano
2021-08-18 10:08 ` Phillip Wood [this message]
2021-08-30 21:19 ` Josh Steadmon
2021-08-12 17:45 ` Philippe Blain
2021-08-12 19:13 ` Junio C Hamano
2021-08-18 10:02 ` Phillip Wood
2021-08-18 22:45 ` Philippe Blain
2021-08-19 10:04 ` Phillip Wood
2021-08-30 21:21 ` Josh Steadmon
2021-08-25 19:40 ` Junio C Hamano
2021-08-30 21:46 ` [PATCH v3] " Josh Steadmon
2021-08-30 22:21 ` Junio C Hamano
2021-08-30 23:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2973f162-d2ab-12da-49ec-82ef823089f6@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).