git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Alex Henrie <alexhenrie24@gmail.com>,
	git@vger.kernel.org, pclouds@gmail.com, gitster@pobox.com
Subject: Re: [PATCH] fetch: improve grammar of "shallow roots" message
Date: Wed, 19 May 2021 09:55:40 -0400	[thread overview]
Message-ID: <2b1985b6-c426-7f7a-2d6b-34977ddecc1d@gmail.com> (raw)
In-Reply-To: <20210518061855.57478-1-alexhenrie24@gmail.com>

On 5/18/2021 2:18 AM, Alex Henrie wrote:
> - warning(_("reject %s because shallow roots are not allowed to be updated"),
> + warning(_("rejected %s because shallow roots are not allowed to be updated"),

This change to past-tense makes sense to me.

Thanks,
-Stolee

  parent reply	other threads:[~2021-05-19 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:18 [PATCH] fetch: improve grammar of "shallow roots" message Alex Henrie
2021-05-19  1:17 ` Junio C Hamano
2021-05-19 13:55 ` Derrick Stolee [this message]
2021-05-20  2:22 ` Bagas Sanjaya
2021-05-20  4:02   ` Alex Henrie
2021-05-20  5:03     ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b1985b6-c426-7f7a-2d6b-34977ddecc1d@gmail.com \
    --to=stolee@gmail.com \
    --cc=alexhenrie24@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).