From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] SubmittingPatches: mention doc-diff
Date: Tue, 21 Aug 2018 15:38:32 -0400 [thread overview]
Message-ID: <2d03be9e-fa89-f740-0c50-3c2d93a29b09@gmail.com> (raw)
In-Reply-To: <20180821192321.GA720@sigill.intra.peff.net>
On 8/21/2018 3:23 PM, Jeff King wrote:
> We already advise people to make sure their documentation
> formats correctly. Let's point them at the doc-diff script,
> which can help with that.
>
> Let's also put a brief note in the script about its purpose,
> since that otherwise can only be found in the original
> commit message. Along with the existing -h/usage text,
> that's hopefully enough for developers to make use of it.
This is helpful, thanks!
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Just a finishing touch on the jk/diff-rendered-docs topic.
>
> Documentation/SubmittingPatches | 4 +++-
> Documentation/doc-diff | 8 ++++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index b44fd51f27..ec8b205145 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -80,7 +80,9 @@ GitHub-Travis CI hints section for details.
>
> Do not forget to update the documentation to describe the updated
> behavior and make sure that the resulting documentation set formats
> -well. It is currently a liberal mixture of US and UK English norms for
> +well (try the Documentation/doc-diff script).
> +
> +We currently have a liberal mixture of US and UK English norms for
> spelling and grammar, which is somewhat unfortunate. A huge patch that
> touches the files all over the place only to correct the inconsistency
> is not welcome, though. Potential clashes with other changes that can
> diff --git a/Documentation/doc-diff b/Documentation/doc-diff
> index f483fe427c..6e285e648c 100755
> --- a/Documentation/doc-diff
> +++ b/Documentation/doc-diff
> @@ -1,4 +1,12 @@
> #!/bin/sh
> +#
> +# Build two documentation trees and diff the resulting formatted output.
> +# Compared to a source diff, this can reveal mistakes in the formatting.
> +# For example:
> +#
> +# ./doc-diff origin/master HEAD
> +#
> +# would show the differences introduced by a branch based on master.
>
> OPTIONS_SPEC="\
> doc-diff [options] <from> <to> [-- <diff-options>]
prev parent reply other threads:[~2018-08-21 19:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 19:23 [PATCH] SubmittingPatches: mention doc-diff Jeff King
2018-08-21 19:35 ` worktree duplicates, was: " Jeff King
2018-08-21 20:22 ` Eric Sunshine
2018-08-21 20:43 ` Jeff King
2018-08-23 18:19 ` Eric Sunshine
2018-08-24 14:46 ` Duy Nguyen
2018-08-24 22:55 ` Eric Sunshine
2018-08-24 23:25 ` Jeff King
2018-08-27 9:55 ` Eric Sunshine
2018-08-27 19:40 ` Jeff King
2018-08-21 19:38 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d03be9e-fa89-f740-0c50-3c2d93a29b09@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).