git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: evgeny <illumsoft.org@gmail.com>
To: git@vger.kernel.org
Subject: t0005-signals.sh fails with ksh
Date: Fri, 8 May 2015 23:15:14 +0300	[thread overview]
Message-ID: <31108626.20150508231514@gmail.com> (raw)

Hi,

Test t0005-signals.sh fails when I run 'make test' under ksh (on Solaris and on Linux)

$ ksh t0005-signals.sh -v
Initialized empty Git repository in /home/test/git/t/trash directory.t0005-signals/.git/
expecting success: 
        { test-sigchain >actual; ret=$?; } &&
        case "$ret" in
        143) true ;; # POSIX w/ SIGTERM=15
        271) true ;; # ksh w/ SIGTERM=15
          3) true ;; # Windows
          *) false ;;
        esac &&
        test_cmp expect actual

t0005-signals.sh[499]: eval: line 4: 23622: Terminated
ok 1 - sigchain works

expecting success: 
        # we use exec here to avoid any sub-shell interpretation
        # of the exit code
        git config alias.sigterm "!exec test-sigchain" &&
        test_expect_code 143 git sigterm

three
two
one
error: exec test-sigchain died of signal 15
ok 2 - signals are propagated using shell convention

expecting success: 
        test-genrandom foo 16384 >file &&
        git add file

ok 3 - create blob

expecting success: 
        OUT=$( ((large_git; echo $? 1>&3) | :) 3>&1 ) &&
        test "$OUT" -eq 141

t0005-signals.sh[499]: eval: syntax error at line 4: `(' unmatched
Memory fault

I rather think there are two issues:
1. two adjacent parentheses
2. numeric constant (141) should be 269 for ksh, like there are two different 
constants in the test 'test-sigchain' in this file (in t0005-signals.sh)

'man ksh' reads:
  (list)
    Execute  list  in  a  separate environment.
    Note, that if two adjacent open parentheses are needed for nesting,
    a space must be inserted to avoid evaluation as an arithmetic command as
    described above.


-- 
Best regards,
 evgeny

             reply	other threads:[~2015-05-08 20:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 20:15 evgeny [this message]
2015-05-08 20:34 ` Junio C Hamano
2015-05-08 20:55   ` Jeff King
2015-05-08 21:14     ` Jeff King
2015-05-08 21:39       ` Junio C Hamano
2015-05-08 23:43         ` evgeny
2015-05-09  8:20         ` Andreas Schwab
2015-05-08 21:16     ` Junio C Hamano
2015-05-08 21:21       ` Jeff King
2015-05-09 20:01         ` brian m. carlson
2015-05-08 23:05   ` evgeny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31108626.20150508231514@gmail.com \
    --to=illumsoft.org@gmail.com \
    --cc=git@vger.kernel.org \
    --subject='Re: t0005-signals.sh fails with ksh' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox