From: Michael J Gruber <git@grubix.eu>
To: git@vger.kernel.org
Cc: Phillip Wood <phillip.wood123@gmail.com>,
Derrick Stolee <derrickstolee@github.com>,
Jeff King <peff@peff.net>
Subject: [PATCH] t3070: make chain lint tester happy
Date: Fri, 24 Mar 2023 23:17:11 +0100 [thread overview]
Message-ID: <3714ba2f6528c38eb9c438126316a08b0cefca7c.1679696180.git.git@grubix.eu> (raw)
In-Reply-To: <13accf6f99d367d137eefd02e3f6bf05bf099e00.1679328580.git.phillip.wood@dunelm.org.uk>
1f2e05f0b7 ("wildmatch: fix exponential behavior", 2023-03-20)
introduced a new test with a background process. Backgrounding
necessarily gives a result of 0, so that a seemingly broken && chain is
not really broken.
Adjust t3070 slightly so that our chain list test recognizes the
construct for what it is and does not raise a false positive.
Signed-off-by: Michael J Gruber <git@grubix.eu>
---
t/t3070-wildmatch.sh | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index b91a7cb712..4dd42df38c 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -432,10 +432,12 @@ match 0 1 0 1 'z' '[Z-y]'
match 1 1 1 1 'Z' '[Z-y]'
test_expect_success 'matching does not exhibit exponential behavior' '
- test-tool wildmatch wildmatch \
- aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaab \
- "*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a" &
- pid=$! &&
+ {
+ test-tool wildmatch wildmatch \
+ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaab \
+ "*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a" &
+ pid=$!
+ } &&
sleep 2 &&
! kill $!
'
--
2.40.0.355.gd681773fb6
next prev parent reply other threads:[~2023-03-24 22:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:09 [PATCH 0/3] wildmatch: fix exponential behavior Phillip Wood
2023-03-20 16:10 ` [PATCH 1/3] " Phillip Wood
2023-03-24 22:17 ` Michael J Gruber [this message]
2023-03-25 6:37 ` [PATCH] t3070: make chain lint tester happy Jeff King
2023-03-25 6:54 ` Eric Sunshine
2023-03-25 7:58 ` Jeff King
2023-03-25 8:04 ` Jeff King
2023-03-25 8:18 ` Eric Sunshine
2023-03-25 8:41 ` Jeff King
2023-03-25 8:51 ` Jeff King
2023-03-25 9:09 ` Eric Sunshine
2023-03-25 19:47 ` Jeff King
2023-03-25 9:17 ` Eric Sunshine
2023-03-26 14:30 ` Phillip Wood
2023-03-26 14:54 ` Michael J Gruber
2023-03-25 8:06 ` Eric Sunshine
2023-03-25 8:36 ` Jeff King
2023-03-20 16:10 ` [PATCH 2/3] wildmatch: avoid undefined behavior Phillip Wood
2023-03-20 16:10 ` [PATCH 3/3] wildmatch: hide internal return values Phillip Wood
2023-03-20 17:58 ` [PATCH 0/3] wildmatch: fix exponential behavior Junio C Hamano
2023-03-23 14:19 ` Derrick Stolee
2023-03-24 14:04 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3714ba2f6528c38eb9c438126316a08b0cefca7c.1679696180.git.git@grubix.eu \
--to=git@grubix.eu \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).