git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: trygveaa@gmail.com, git@vger.kernel.org,
	larsxschneider@gmail.com, chriscool@tuxfamily.org,
	Johannes.Schindelin@gmx.de, pranit.bauva@gmail.com,
	tanushreetumane@gmail.com, mirucam@gmail.com
Subject: Re: [PATCH v2] test: add test for git bisect skip with --term* arguments
Date: Thu, 22 Apr 2021 12:16:30 +0700	[thread overview]
Message-ID: <3bbc9350-60cd-9fb2-117a-add3dc5cf77e@gmail.com> (raw)
In-Reply-To: <xmqqa6przh08.fsf@gitster.g>

On 22/04/21 00.25, Junio C Hamano wrote:
> I expected, as you said in your first version, that it would be
> added as part of an existing test script for "git bisect".  And I
> suspect that you can reuse the history the existing tests in the
> script already use, so you won't have to add the first "initialize"
> piece.  If the tested sequence should work but does not yet work due
> to lack of a fix to a known bug, the test should be marked as
> test_expect_failure instead of test_expect_success.

So will this patch be queued? Or should I send the patch adding this
test to t6030 instead of separate test script here?

-- 
An old man doll... just what I always wanted! - Clara

      reply	other threads:[~2021-04-22  5:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 15:14 Using --term-* with bisect breaks skip Trygve Aaberge
2021-04-19  6:58 ` Bagas Sanjaya
2021-04-19  8:39   ` Trygve Aaberge
2021-04-19 12:50     ` Bagas Sanjaya
2021-04-19 18:55 ` Junio C Hamano
2021-04-19 19:32   ` Trygve Aaberge
2021-04-20 12:34 ` [PATCH] test: add test for git bisect skip with --term* arguments Bagas Sanjaya
2021-04-20 18:08   ` Junio C Hamano
2021-04-21  4:08 ` [PATCH v2] " Bagas Sanjaya
2021-04-21 17:25   ` Junio C Hamano
2021-04-22  5:16     ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bbc9350-60cd-9fb2-117a-add3dc5cf77e@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    --cc=mirucam@gmail.com \
    --cc=pranit.bauva@gmail.com \
    --cc=tanushreetumane@gmail.com \
    --cc=trygveaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).