git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] t64??: convert 'test_create_repo' to 'git init'
Date: Mon, 22 Aug 2022 14:46:05 +0200 (CEST)	[thread overview]
Message-ID: <3pso553o-rr64-9412-n1q3-q2n457r51448@tzk.qr> (raw)
In-Reply-To: <pull.1303.git.git.1661034837118.gitgitgadget@gmail.com>

Hi Elijah,

On Sat, 20 Aug 2022, Elijah Newren via GitGitGadget wrote:

> From: Elijah Newren <newren@gmail.com>
>
> As promised[1], convert the merge-specific tests over to using 'git
> init' instead of 'test_create_repo'.
>
> [1] https://lore.kernel.org/git/CABPp-BEcojvfeuhp7rSi-O+9oEu4KpwPDwbKS-MiD1qCKde-CA@mail.gmail.com/
>
> Signed-off-by: Elijah Newren <newren@gmail.com>

Large patch, but easy to review, and the commit message is clear (and
despite being short, follows the structure outlined in
https://github.blog/2022-06-30-write-better-commits-build-better-projects/:
Intent, Context, Implementation and Justification).

Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Thank you,
Dscho

  reply	other threads:[~2022-08-22 12:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-20 22:33 [PATCH] t64??: convert 'test_create_repo' to 'git init' Elijah Newren via GitGitGadget
2022-08-22 12:46 ` Johannes Schindelin [this message]
2022-08-26  3:49 ` [PATCH v2] t64xx: " Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3pso553o-rr64-9412-n1q3-q2n457r51448@tzk.qr \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).