From: Jeff Hostetler <git@jeffhostetler.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v7 09/16] fetch: support filters
Date: Mon, 20 Aug 2018 15:42:33 -0400 [thread overview]
Message-ID: <409954a1-6aff-f187-ec3e-c0bf044d279f@jeffhostetler.com> (raw)
In-Reply-To: <CACsJy8D3nC+fXFYMKWh6AStbMVOVfmcAvAT9tBqtG9K6r043eQ@mail.gmail.com>
On 8/19/2018 7:24 AM, Duy Nguyen wrote:
> On Fri, Dec 8, 2017 at 5:00 PM Jeff Hostetler <git@jeffhostetler.com> wrote:
>>
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Teach fetch to support filters. This is only allowed for the remote
>> configured in extensions.partialcloneremote.
>>
>> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
>> ---
>> builtin/fetch.c | 23 +++++++++++++++++++++--
>> connected.c | 2 ++
>> remote-curl.c | 6 ++++++
>> t/t5500-fetch-pack.sh | 36 ++++++++++++++++++++++++++++++++++++
>> 4 files changed, 65 insertions(+), 2 deletions(-)
>>
>> diff --git a/builtin/fetch.c b/builtin/fetch.c
>> index 1b1f039..14aab71 100644
>> --- a/builtin/fetch.c
>> +++ b/builtin/fetch.c
>> @@ -18,6 +18,7 @@
>> #include "argv-array.h"
>> #include "utf8.h"
>> #include "packfile.h"
>> +#include "list-objects-filter-options.h"
>>
>> static const char * const builtin_fetch_usage[] = {
>> N_("git fetch [<options>] [<repository> [<refspec>...]]"),
>> @@ -55,6 +56,7 @@ static int recurse_submodules_default = RECURSE_SUBMODULES_ON_DEMAND;
>> static int shown_url = 0;
>> static int refmap_alloc, refmap_nr;
>> static const char **refmap_array;
>> +static struct list_objects_filter_options filter_options;
>>
>> static int git_fetch_config(const char *k, const char *v, void *cb)
>> {
>> @@ -160,6 +162,7 @@ static struct option builtin_fetch_options[] = {
>> TRANSPORT_FAMILY_IPV4),
>> OPT_SET_INT('6', "ipv6", &family, N_("use IPv6 addresses only"),
>> TRANSPORT_FAMILY_IPV6),
>> + OPT_PARSE_LIST_OBJECTS_FILTER(&filter_options),
>
> Documentation is missing. Please add something to git-fetch.txt (or
> fetch-options.txt) about this option. I would make a patch but I don't
> know enough about this to write and I'm in the middle of something
> else.
>
Documentation for --filter=<fs> (and --no-filter) were added to
rev-list-options.txt. The opening paragraph talks about --objects
which would need to be omitted for fetch and clone, but the rest
of that text is relevant.
I'll push up a patch shortly.
Thanks
Jeff
next prev parent reply other threads:[~2018-08-20 19:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 15:58 [PATCH v7 00/16] Parial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 01/16] sha1_file: support lazily fetching missing objects Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 02/16] rev-list: support termination at promisor objects Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 03/16] gc: do not repack promisor packfiles Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 04/16] upload-pack: add object filtering for partial clone Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 05/16] fetch-pack, index-pack, transport: " Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 06/16] fetch-pack: add --no-filter Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 07/16] fetch-pack: test support excluding large blobs Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 08/16] fetch: refactor calculation of remote list Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 09/16] fetch: support filters Jeff Hostetler
2018-08-19 11:24 ` Duy Nguyen
2018-08-20 19:42 ` Jeff Hostetler [this message]
2017-12-08 15:58 ` [PATCH v7 10/16] partial-clone: define partial clone settings in config Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 11/16] clone: partial clone Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 12/16] unpack-trees: batch fetching of missing blobs Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 13/16] fetch-pack: restore save_commit_buffer after use Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 14/16] t5616: end-to-end tests for partial clone Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 15/16] fetch: inherit filter-spec from " Jeff Hostetler
2017-12-08 15:58 ` [PATCH v7 16/16] t5616: test bulk prefetch after partial fetch Jeff Hostetler
2017-12-08 17:58 ` [PATCH v7 00/16] Parial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests Junio C Hamano
2017-12-08 18:10 ` Jeff Hostetler
2017-12-08 18:23 ` Junio C Hamano
2017-12-08 22:30 ` Brandon Williams
2017-12-11 19:19 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409954a1-6aff-f187-ec3e-c0bf044d279f@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).