git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Victoria Dye <vdye@github.com>
To: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Derrick Stolee <derrickstolee@github.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	ZheNing Hu <adlternative@gmail.com>
Subject: Re: [PATCH] scalar: fix wrong shell hashbang
Date: Sun, 18 Sep 2022 13:08:33 -0700	[thread overview]
Message-ID: <433bf552-db20-9989-92c5-ee625ce9337a@github.com> (raw)
In-Reply-To: <pull.1355.git.1663420281187.gitgitgadget@gmail.com>

ZheNing Hu via GitGitGadget wrote:
> From: ZheNing Hu <adlternative@gmail.com>
> 
> $SHELL_PATH_SQ haven't been set in scalar's Makefile,
> bin-wrappers/scalar will begin with wrong hashbang "#!",
> fix it by setting $SHELL_PATH and $SHELL_PATH_SQ in
> scalar's Makefile.
> 
> Signed-off-by: ZheNing Hu <adlternative@gmail.com>
> ---
>     scalar: fix wrong shell hashbang
>     
>     The bin-wrappers/scalar seems like missing setting $SHELL_PATH_SQ which
>     lead to I can't execute bin-wrappers/scalar correctly, which output
>     error:
>     
>     zsh: exec format error: scalar
>     
>     (this bug will not turn out in bash)
>     
>     The bin-wrappers/scalar begin with wrong hashbang "#!", which cannot
>     figure out by zsh. So this patch want to fix this problem.
>     
>     v1: Setting $SHELL_PATH and $SHELL_PATH_SQ in scalar/Makefile.
> 

Thanks for finding this! However, while your patch fixes the error you've
identified (I was able to recreate both the original issue and apply your
patch to fix it), I believe it has already been fixed in 'next' by
7b5c93c6c6 (scalar: include in standard Git build & installation,
2022-09-02) (archive: [1]).

[1] https://lore.kernel.org/git/bc2092a7a7aae640b547bde8db0c0a26ce31278a.1662134210.git.gitgitgadget@gmail.com/

  reply	other threads:[~2022-09-18 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17 13:11 [PATCH] scalar: fix wrong shell hashbang ZheNing Hu via GitGitGadget
2022-09-18 20:08 ` Victoria Dye [this message]
2022-09-19 18:44   ` Junio C Hamano
2022-09-20 12:43   ` ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=433bf552-db20-9989-92c5-ee625ce9337a@github.com \
    --to=vdye@github.com \
    --cc=adlternative@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).