From: Alex Blewitt <alex.blewitt@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop
Date: Wed, 6 May 2009 21:50:57 +0100 [thread overview]
Message-ID: <46FFA889-7EFA-4CF2-9493-81DF5A319B6C@gmail.com> (raw)
In-Reply-To: <20090506204849.GM30527@spearce.org>
I've been using git send-email --format-patch, which doesn't appear to
add the signed by line. If I do it as the commit, will it add the
signed-by when it gets committed, and thus I can use send-email? git
format-patch just seems to dump a load of files into the directory,
and (as noted elsewhere) the git-rebase doesn't appear to work for me.
Alex
On 6 May 2009, at 21:48, Shawn O. Pearce wrote:
> Alex Blewitt <alex.blewitt@gmail.com> wrote:
>> ---
>> .../src/org/spearce/jgit/lib/PackWriter.java | 25 +++++++++
>> +---------
>> 1 files changed, 13 insertions(+), 12 deletions(-)
>
> Also, I'd like a Signed-off-by line for your patches. We follow
> Linux kernel tradition and use a Signed-off-by line to mean
> you agree to the "Developer's Certificate of Origin 1.1" (see
> SUBMITTING_PATCHES in the top level directory, part 5).
>
> For the 2 that you've submitted thus far (this one, and the make
> private constructor) you can just reply to the email and drop the
> SOB line into the message body. In the future make sure you add
> it in with git commit -s or git format-patch -s prior to sending.
>
> --
> Shawn.
next prev parent reply other threads:[~2009-05-06 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 20:37 [PATCH 1/2] Allow monitor/unintersting objects to be null Alex Blewitt
2009-05-06 20:37 ` [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop Alex Blewitt
2009-05-06 20:41 ` Shawn O. Pearce
2009-05-06 20:48 ` Shawn O. Pearce
2009-05-06 20:50 ` Alex Blewitt [this message]
2009-05-06 20:54 ` Shawn O. Pearce
2009-05-06 21:10 ` [PATCH 1/2] Allow monitor/unintersting objects to be null Robin Rosenberg
2009-05-06 21:28 ` Alex Blewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FFA889-7EFA-4CF2-9493-81DF5A319B6C@gmail.com \
--to=alex.blewitt@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).