From: Johannes Sixt <j.sixt@viscovery.net>
To: Ping Yin <pkufranky@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/3] builtin-status: submodule summary support
Date: Wed, 12 Mar 2008 08:33:39 +0100 [thread overview]
Message-ID: <47D78753.2040902@viscovery.net> (raw)
In-Reply-To: <1205288512-20435-1-git-send-email-pkufranky@gmail.com>
Ping Yin schrieb:
> +static void wt_status_print_submodule_summary(struct wt_status *s)
> +{
> + struct child_process sm_summary;
> + const char *argv[] = {
> + "submodule",
> + "summary",
> + "--cached",
> + "--for-status",
> + "--summary-limit",
> + summary_limit,
Where is summary_limit? Did you split this patch series incorrectly?
> + s->amend ? "HEAD^" : "HEAD",
Any chance that we avoid "HEAD^" here? Perhaps we have the SHA1 around
somewhere? I fear that our MSYS bash mangles it into "HEAD". I shall test it.
BTW, you don't mention the prerequisites of this series. I assume it
builds on top of your "[PATCH v5 0/5] git-submodule summary" series.
> + sm_summary.no_stderr = 1;
Why this? If the submodule summary has errors we certainly want to see them.
> @@ -321,6 +349,9 @@ void wt_status_print(struct wt_status *s)
> }
>
> wt_status_print_changed(s);
> + // must flush s->fp since following call will write to s->fp in a child process
> + fflush(s->fp);
> + wt_status_print_submodule_summary(s);
Hmm. Aren't you unconditionally spawning "git submodule summary" for each
git-status/git-commit?
-- Hannes
next prev parent reply other threads:[~2008-03-12 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 2:21 [PATCH 1/3] builtin-status: submodule summary support Ping Yin
2008-03-12 2:21 ` [PATCH 2/3] builtin-status: configurable submodule summary size Ping Yin
2008-03-12 2:21 ` [PATCH 3/3] buitin-status: Add tests for submodule summary Ping Yin
2008-03-12 7:38 ` Johannes Sixt
2008-03-12 7:33 ` Johannes Sixt [this message]
2008-03-13 13:05 ` [PATCH 1/3] builtin-status: submodule summary support Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D78753.2040902@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).