From: Dragan Simic <dsimic@manjaro.org>
To: git@vger.kernel.org
Cc: gitster@pobox.com, rsbecker@nexbridge.com, github@seichter.de,
sunshine@sunshineco.com
Subject: [PATCH v2 3/5] test: introduce new x_to_tab() helper function
Date: Sun, 17 Mar 2024 04:48:03 +0100 [thread overview]
Message-ID: <480b46f2db82ea9c6cd9bbc2423923f81f2d36f5.1710646998.git.dsimic@manjaro.org> (raw)
In-Reply-To: <cover.1710646998.git.dsimic@manjaro.org>
There's nothing wrong with the already existing q_to_tab() function, except
when it's used on strings that contain uppercase letter "Q" in its literal
meaning, which, for example, can happen with git configurations that contain
"*.*Quoted" as the names of their configuration variables.
Thus, let's introduce new x_to_tab() helper function that does pretty much
the same job as the already existing q_to_tab() helper function, except for
replacing "X" with a horizontal tab (HT), instead of replacing "Q".
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
---
Notes:
This patch didn't exist in the v1 of this patch series.
t/test-lib-functions.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 6eaf116346be..362d3205b7b0 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -107,6 +107,10 @@ q_to_tab () {
tr Q '\011'
}
+x_to_tab () {
+ tr X '\011'
+}
+
qz_to_tab_space () {
tr QZ '\011\040'
}
next prev parent reply other threads:[~2024-03-17 3:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 3:48 [PATCH v2 0/5] Fix a bug in configuration parsing, and improve tests and documentation Dragan Simic
2024-03-17 3:48 ` [PATCH v2 1/5] config: minor addition of whitespace Dragan Simic
2024-03-17 3:48 ` [PATCH v2 2/5] config: really keep value-internal whitespace verbatim Dragan Simic
2024-03-17 3:48 ` Dragan Simic [this message]
2024-03-17 4:03 ` [PATCH v2 3/5] test: introduce new x_to_tab() helper function Eric Sunshine
2024-03-17 4:16 ` Dragan Simic
2024-03-17 3:48 ` [PATCH v2 4/5] t1300: add more tests for whitespace and inline comments Dragan Simic
2024-03-17 4:21 ` Eric Sunshine
2024-03-17 4:27 ` Eric Sunshine
2024-03-17 4:50 ` Dragan Simic
2024-03-18 2:48 ` Eric Sunshine
2024-03-18 4:38 ` Junio C Hamano
2024-03-18 8:37 ` Dragan Simic
2024-03-18 19:21 ` Eric Sunshine
2024-03-18 21:57 ` Dragan Simic
2024-03-18 8:17 ` Dragan Simic
2024-03-18 19:17 ` Eric Sunshine
2024-03-18 20:28 ` Junio C Hamano
2024-03-18 21:54 ` Dragan Simic
2024-03-17 3:48 ` [PATCH v2 5/5] config.txt: describe handling of whitespace further Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480b46f2db82ea9c6cd9bbc2423923f81f2d36f5.1710646998.git.dsimic@manjaro.org \
--to=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=github@seichter.de \
--cc=gitster@pobox.com \
--cc=rsbecker@nexbridge.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).