From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Weird problem with long $PATH and alternates (bisected)
Date: Sun, 26 Oct 2008 18:53:17 +0100 [thread overview]
Message-ID: <4904AE8D.9090706@lsrfire.ath.cx> (raw)
In-Reply-To: <7vljwb5o4p.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> "Mikael Magnusson" <mikachu@gmail.com> writes:
>
>> % mkdir 1; cd 1
>> % echo > a; git add a; git commit -m a
>> % cd ..
>> % git clone -s 1 2
>> % git push . master:master
>> fatal: Could not switch to
>> '/tmp/a/1/.git/objects/n:/usr/games/bin:/usr/local/ipod-chain'
>> fatal: The remote end hung up unexpectedly
>
> I think I see a bug in foreach_alt_odb() to add_refs_from_alternate()
> callchain, but I cannot explain why the contents of $PATH leaks to the
> error message.
With the following patch, I can no longer reproduce the problem. Does it
work fo you, too?
Thanks,
René
diff --git a/sha1_file.c b/sha1_file.c
index ab2b520..8044e9c 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -269,7 +269,7 @@ static int link_alt_odb_entry(const char * entry, int len, const char * relative
entlen += base_len;
pfxlen += base_len;
}
- ent = xmalloc(sizeof(*ent) + entlen);
+ ent = xcalloc(1, sizeof(*ent) + entlen);
if (!is_absolute_path(entry) && relative_base) {
memcpy(ent->base, relative_base, base_len - 1);
next prev parent reply other threads:[~2008-10-26 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 14:46 Weird problem with long $PATH and alternates (bisected) Mikael Magnusson
2008-10-26 16:15 ` Junio C Hamano
2008-10-26 16:49 ` Mikael Magnusson
2008-10-26 17:53 ` René Scharfe [this message]
2008-10-26 18:07 ` Junio C Hamano
2008-10-26 18:29 ` Mikael Magnusson
2008-10-27 5:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4904AE8D.9090706@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mikachu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).