From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, tb <tboegi@web.de>
Subject: Re: [RFC][PATCH v2] git on Mac OS and precomposed unicode
Date: Fri, 13 Jan 2012 22:52:46 +0100 [thread overview]
Message-ID: <4F10A7AE.6030004@web.de> (raw)
In-Reply-To: <7vd3asejrr.fsf@alter.siamese.dyndns.org>
On 01/09/2012 08:52 PM, Junio C Hamano wrote:
[snip]
>probe_utf8_pathname_composition(path, len);
Done
[snip]
>and implementation of the function body in compat/darwin.c (Didn't I see a
>comment on the name of this file, by the way? What was the conclusion of
> the discussion?).
I renamed the compat/darwin.[ch] into compat/precomposed_utf8.[ch]
>> +{
>> + int i = 0;
>> + int first_arg = 0; /* convert everything */
>> + const char *oldarg;
>> + char *newarg;
>> + iconv_t ic_precompose;
>> +
>> + git_config(precomposed_unicode_config, NULL);
>
> Hmmmmm. Is it safe to call git_config() this early in the program? Have
> we determined if we are in a git managed repository and where its $GIT_DIR
> is?
>
According to my understanding, yes:
git_config is called with the custom function precomposed_unicode_config():
git_config(precomposed_unicode_config, NULL);
where
precomposed_unicode_config()
fishes for the config variable "core.precomposedunicode" and puts the
result into
int precomposed_unicode_config.
After that, when precomposed_unicode_config==0, argv_precomposed() will
return.
I'll send the V3 RFC/PATCH
/Torsten
next prev parent reply other threads:[~2012-01-13 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 16:45 [RFC][PATCH v2] git on Mac OS and precomposed unicode Torsten Bögershausen
2012-01-09 19:52 ` Junio C Hamano
2012-01-13 21:52 ` Torsten Bögershausen [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-09 16:45 Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F10A7AE.6030004@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).