git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 1/3] t3404: add a test for the --gpg-sign option
Date: Thu, 7 Jul 2016 17:52:50 +0200 (CEST)	[thread overview]
Message-ID: <4fe1c1b7598f3c5ddc0cf8f9c0ef89ac193a22e2.1467906747.git.johannes.schindelin@gmx.de> (raw)
In-Reply-To: <cover.1467906747.git.johannes.schindelin@gmx.de>

For the upcoming rebase--helper work (which will accelerate the
interactive rebase noticably), it is important to verify that the
--gpg-sign option is handled properly.

Please note that this patch does this on the cheap, by verifying that
the expected option is printed in the message of the 'edit' operation.

We really should test that the interactive rebase signs the commits
properly, iff GPG is available. This test is left for later.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t3404-rebase-interactive.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 66348f1..aa393d2 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -1281,4 +1281,12 @@ test_expect_success 'editor saves as CR/LF' '
 	)
 '
 
+SQ="'"
+test_expect_success 'rebase -i --gpg-sign=<key-id>' '
+	set_fake_editor &&
+	FAKE_LINES="edit 1" git rebase -i --gpg-sign="\"S I Gner\"" HEAD^ \
+		>out 2>err &&
+	grep "$SQ-S\"S I Gner\"$SQ" err
+'
+
 test_done
-- 
2.9.0.278.g1caae67



  reply	other threads:[~2016-07-07 15:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 14:30 [PATCH 0/2] Late edits to the rebase -i tests Johannes Schindelin
2016-06-29 14:31 ` [PATCH 1/2] t3404: fix another typo Johannes Schindelin
2016-06-29 15:11   ` Pranit Bauva
2016-06-29 15:26   ` Junio C Hamano
2016-06-29 15:31     ` Johannes Schindelin
2016-06-29 18:06       ` Junio C Hamano
2016-06-30  8:17         ` Johannes Schindelin
2016-06-29 14:31 ` [PATCH 2/2] t3404: add a test for the --gpg-sign option Johannes Schindelin
2016-06-29 18:30   ` Junio C Hamano
2016-06-30  8:25     ` Johannes Schindelin
2016-07-01 16:06       ` Junio C Hamano
2016-07-02  7:38         ` Johannes Schindelin
2016-07-06 14:51           ` Junio C Hamano
2016-07-06 15:34             ` Johannes Schindelin
2016-07-06 19:02               ` Junio C Hamano
2016-07-07 15:23                 ` Johannes Schindelin
2016-07-07 15:52 ` [PATCH v2 0/3] Additional rebase -i tests Johannes Schindelin
2016-07-07 15:52   ` Johannes Schindelin [this message]
2016-07-07 15:52   ` [PATCH v2 2/3] rebase -i: demonstrate a bug with --autosquash Johannes Schindelin
2016-07-07 15:52   ` [PATCH v2 3/3] rebase -i: we allow extra spaces after fixup!/squash! Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fe1c1b7598f3c5ddc0cf8f9c0ef89ac193a22e2.1467906747.git.johannes.schindelin@gmx.de \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).