From: Felipe Contreras <felipe.contreras@gmail.com>
To: Krzysztof Mazur <krzysiek@podlesie.net>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] Add core.mode configuration
Date: Tue, 15 Oct 2013 13:51:41 -0500 [thread overview]
Message-ID: <525d8ebd19c67_5feab61e8037@nysa.notmuch> (raw)
In-Reply-To: <20131015145139.GA3977@shrek.podlesie.net>
Krzysztof Mazur wrote:
> On Tue, Oct 15, 2013 at 08:29:56AM -0500, Felipe Contreras wrote:
> > Krzysztof Mazur wrote:
> > > On Tue, Oct 15, 2013 at 07:32:39AM -0500, Felipe Contreras wrote:
> > > > Krzysztof Mazur wrote:
> > > > >
> > > > > But with core.mode = next after upgrade you may experience incompatible
> > > > > change without any warning.
> > > >
> > > > Yes, and that is actually what the user wants. I mean, why would the user set
> > > > core.mode=next, if the user doesn't want to experencie incompatible changes? A
> > > > user that sets this mode is expecting incompatible changes, and will be willing
> > > > to test them, and report back if there's any problem with them.
> > >
> > > With your patch, because it's the only way to have 'git add' v2.0.
> >
> > Yeah, but that's not what I'm suggesting. I suggested to have *both* a
> > fined-tunned way to have this behavior, say core.addremove = true, and a way to
> > enable *all* v2.0 behaviors (core.mode = next).
>
> I'm just not sure if a lot of users would use core.mode=next,
I'm not sure if a lot of urser would even notice the difference.
> because of possible different behavior without any warning.
I don't see what is the problem. We haven't had the need for push.default =
simplewarning, have we? If you want the warning, you don't change anything, if
you want to specify something, you already know what you are doing.
> Maybe we should also add core.mode=next-warn that changes defaults like next
> but keeps warnings enabled until the user accepts that change by setting
> appropriate config option?
Maybe, but would you actually use that option?
> That's safer than next (at least for interactive use) and maybe more users
> would use that, but I don't think that's worth adding.
Maybe, but I don't think many users would use either mode, and that's good.
> For me, old behavior by default and warnings with information how to
> enable new incompatible features, is sufficient. So I don't need
> core.mode option, but as long it will be useful for other users I have
> nothing against it.
OK, but that seems to mean you don't need core.mode = next-warn either. I'm not
against adding such a mode, but I would like to hear about _somebody_ that
would like to actually use it. I don't like to program for ghosts.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2013-10-15 19:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 7:04 [PATCH v3] Add core.mode configuration Felipe Contreras
2013-10-14 20:59 ` Krzysztof Mazur
2013-10-14 21:35 ` Felipe Contreras
2013-10-15 12:35 ` Krzysztof Mazur
2013-10-15 12:32 ` Felipe Contreras
2013-10-15 13:33 ` Krzysztof Mazur
2013-10-15 13:29 ` Felipe Contreras
2013-10-15 14:51 ` Krzysztof Mazur
2013-10-15 16:59 ` John Szakmeister
2013-10-16 3:55 ` Felipe Contreras
2013-10-16 7:09 ` Krzysztof Mazur
2013-10-16 19:31 ` Felipe Contreras
2013-10-16 10:54 ` John Szakmeister
2013-10-16 15:11 ` John Szakmeister
2013-10-16 19:57 ` Felipe Contreras
2013-10-16 19:32 ` Felipe Contreras
2013-10-16 22:02 ` Philip Oakley
2013-10-16 23:06 ` Jonathan Nieder
2013-10-17 19:48 ` Philip Oakley
2013-10-17 21:08 ` Felipe Contreras
2013-10-15 18:51 ` Felipe Contreras [this message]
2013-10-15 22:01 ` Krzysztof Mazur
2013-10-16 4:03 ` Felipe Contreras
2013-10-16 6:34 ` Krzysztof Mazur
2013-10-16 19:28 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525d8ebd19c67_5feab61e8037@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=krzysiek@podlesie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).