From: Karsten Blees <karsten.blees@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH v7 11/16] trace: add 'file:line' to all trace output
Date: Wed, 02 Jul 2014 21:05:52 +0200 [thread overview]
Message-ID: <53B45810.9000806@gmail.com> (raw)
In-Reply-To: <xmqqionfh9lp.fsf@gitster.dls.corp.google.com>
Am 02.07.2014 20:57, schrieb Junio C Hamano:
> Karsten Blees <karsten.blees@gmail.com> writes:
>
>> +#else
>> +
>> +/*
>> + * Macros to add file:line - see above for C-style declarations of how these
>> + * should be used.
>> + *
>> + * TRACE_CONTEXT may be set to __FUNCTION__ if the compiler supports it. The
>> + * default is __FILE__, as it is consistent with assert(), and static function
>> + * names are not necessarily unique.
>> + */
>> +#define TRACE_CONTEXT __FILE__
>
> Hmph, seeing "may be set to" forces me to wonder how. Perhaps #ifndef/#endif
> around it?
>
Right, shame on me. I didn't think it would be important enough to warrant a
Makefile option, but #ifndef sure wouldn't hurt.
> Also, can it be set to something like __FILE__ ":" __FUNCTION__
> which may alleviate the alleged problem of "not necessarily unique"
> perhaps?
>
Should work with MSVC. With GCC, however, __FUNCTION__ is a string constant
supplied by the compiler, so string literal concatenation doesn't work.
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-07-02 19:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 22:53 [PATCH v7 00/16] add performance tracing facility Karsten Blees
2014-07-01 22:55 ` [PATCH v7 01/16] trace: move trace declarations from cache.h to new trace.h Karsten Blees
2014-07-01 22:56 ` [PATCH v7 02/16] trace: consistently name the format parameter Karsten Blees
2014-07-01 22:56 ` [PATCH v7 03/16] trace: remove redundant printf format attribute Karsten Blees
2014-07-01 22:57 ` [PATCH v7 04/16] trace: improve trace performance Karsten Blees
2014-07-02 18:15 ` Junio C Hamano
2014-07-01 22:58 ` [PATCH v7 05/16] Documentation/git.txt: improve documentation of 'GIT_TRACE*' variables Karsten Blees
2014-07-01 22:58 ` [PATCH v7 06/16] sha1_file: change GIT_TRACE_PACK_ACCESS logging to use trace API Karsten Blees
2014-07-01 22:59 ` [PATCH v7 07/16] trace: add infrastructure to augment trace output with additional info Karsten Blees
2014-07-01 22:59 ` [PATCH v7 08/16] trace: disable additional trace output for unit tests Karsten Blees
2014-07-01 23:00 ` [PATCH v7 09/16] trace: add current timestamp to all trace output Karsten Blees
2014-07-01 23:01 ` [PATCH v7 10/16] trace: move code around, in preparation to file:line output Karsten Blees
2014-07-01 23:02 ` [PATCH v7 11/16] trace: add 'file:line' to all trace output Karsten Blees
2014-07-02 18:57 ` Junio C Hamano
2014-07-02 19:05 ` Karsten Blees [this message]
2014-07-02 19:12 ` Junio C Hamano
2014-07-01 23:02 ` [PATCH v7 12/16] trace: add high resolution timer function to debug performance issues Karsten Blees
2014-07-01 23:03 ` [PATCH v7 13/16] trace: add trace_performance facility " Karsten Blees
2014-07-01 23:03 ` [PATCH v7 14/16] git: add performance tracing for git's main() function to debug scripts Karsten Blees
2014-07-01 23:04 ` [PATCH v7 15/16] wt-status: simplify performance measurement by using getnanotime() Karsten Blees
2014-07-01 23:05 ` [PATCH v7 16/16] progress: " Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B45810.9000806@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).