From: Sven Strickroth <sven@cs-ware.de>
To: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH] Close config file handle if the entry to unset is not found
Date: Fri, 14 Aug 2015 21:18:59 +0200 [thread overview]
Message-ID: <55CE3F23.7040702@cs-ware.de> (raw)
Without this patch there might be open handle leaks.
Signed-off-by: Sup Yut Sum <ch3cooli@gmail.com>
Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/config.c b/config.c
index 9fd275f..89b49e3 100644
--- a/config.c
+++ b/config.c
@@ -2048,6 +2048,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
if ((store.seen == 0 && value == NULL) ||
(store.seen > 1 && multi_replace == 0)) {
ret = CONFIG_NOTHING_SET;
+ close(in_fd);
goto out_free;
}
--
Best regards,
Sven Strickroth
PGP key id F5A9D4C4 @ any key-server
next reply other threads:[~2015-08-14 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 19:18 Sven Strickroth [this message]
2015-08-14 19:35 ` [PATCH] Close config file handle if the entry to unset is not found Eric Sunshine
2015-08-14 19:38 ` Sven Strickroth
2015-08-14 19:44 ` [PATCH] Correctly close config file handle in case of error Sven Strickroth
2015-08-14 19:54 ` Eric Sunshine
2015-08-14 20:03 ` Sven Strickroth
2015-08-14 20:14 ` Eric Sunshine
2015-08-14 20:21 ` Sven Strickroth
2015-08-14 20:32 ` Eric Sunshine
2015-08-14 21:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CE3F23.7040702@cs-ware.de \
--to=sven@cs-ware.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).