git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: RE: [PATCH] SubmittingPatches: tighten wording on "sign-off" procedure
Date: Mon, 28 Dec 2020 08:09:53 -0600	[thread overview]
Message-ID: <5fe9e731de0e5_209d20845@natae.notmuch> (raw)
In-Reply-To: <xmqqh7o6jjt1.fsf@gitster.c.googlers.com>

Junio C Hamano wrote:
> The text says "if you can certify DCO then you add a Singed-off-by
> trailer".  But it does not say anything about people who cannot
> certify.  A natural reading may be that if you cannot certify, you
> do not add the trailer, but it shouldn't hurt to be overly explicit.

It doesn't matter if a person *can* certify, what matters is if the
person *does* certify.

In a weeding ceremony when asked "do you take this woman to be your
wife?", the answer that is looked for is not "I can".

Do you or don't you? Is the question.

> diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches
> index d12094bac5..b091730771 100644
> --- c/Documentation/SubmittingPatches
> +++ w/Documentation/SubmittingPatches
> @@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license
>  as ours, by "signing off" your patch.  Without sign-off, we cannot
>  accept your patches.
>  
> -If you can certify the below D-C-O:
> +If (and only if) you can certify the below D-C-O:

If you certify the bellow D-C-O:

>  [[dco]]
>  .Developer's Certificate of Origin 1.1
>  ____

-- 
Felipe Contreras

  reply	other threads:[~2020-12-28 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 10:39 [PATCH] SubmittingPatches: tighten wording on "sign-off" procedure Junio C Hamano
2020-12-28 14:09 ` Felipe Contreras [this message]
2020-12-28 19:19   ` Junio C Hamano
2020-12-28 15:19 ` Derrick Stolee
2021-01-07 23:38 ` [PATCH v2] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fe9e731de0e5_209d20845@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).