From: Felipe Contreras <felipe.contreras@gmail.com>
To: Gregory Anders <greg@gpanders.com>, git@vger.kernel.org
Subject: RE: [PATCH v3] git-send-email: use ! to indicate relative path to command
Date: Tue, 11 May 2021 15:03:58 -0500 [thread overview]
Message-ID: <609ae32e3b9f_60649208e0@natae.notmuch> (raw)
In-Reply-To: <20210511191510.25888-1-greg@gpanders.com>
Gregory Anders wrote:
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1492,11 +1492,14 @@ sub send_message {
>
> if ($dry_run) {
> # We don't want to send the email.
> - } elsif (file_name_is_absolute($smtp_server)) {
> + } elsif (file_name_is_absolute($smtp_server) || $smtp_server =~ /^!/) {
Is there any particular reason why we are checking for an absolute path?
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-11 20:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 19:15 [PATCH v3] git-send-email: use ! to indicate relative path to command Gregory Anders
2021-05-11 19:24 ` Jeff King
2021-05-11 20:40 ` [PATCH v4] " Gregory Anders
2021-05-11 21:39 ` Jeff King
2021-05-11 22:18 ` Gregory Anders
2021-05-11 23:09 ` Junio C Hamano
2021-05-11 23:49 ` [PATCH v5] " Gregory Anders
2021-05-12 0:00 ` brian m. carlson
2021-05-12 0:35 ` Jeff King
2021-05-12 0:45 ` Gregory Anders
2021-05-12 0:49 ` Jeff King
2021-05-12 3:29 ` Junio C Hamano
2021-05-12 0:51 ` brian m. carlson
2021-05-11 20:03 ` Felipe Contreras [this message]
2021-05-11 20:42 ` [PATCH v3] " Gregory Anders
2021-05-11 22:07 ` Felipe Contreras
2021-05-11 22:19 ` Gregory Anders
2021-05-12 0:47 ` Jeff King
2021-05-12 1:08 ` Felipe Contreras
2021-05-12 1:24 ` Jeff King
2021-05-12 1:52 ` Felipe Contreras
2021-05-12 1:58 ` Gregory Anders
2021-05-12 4:17 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609ae32e3b9f_60649208e0@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=greg@gpanders.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).