git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Dave Huseby <dwh@linuxprogrammer.org>,
	git@vger.kernel.org
Cc: christian.couder@gmail.com, felipe.contreras@gmail.com,
	gitster@pobox.com, stefanmoch@mail.de
Subject: Re: [PATCH v2] Writing down mail list etiquette.
Date: Wed, 12 May 2021 01:45:14 -0500	[thread overview]
Message-ID: <609b797a818bb_6d897208ce@natae.notmuch> (raw)
In-Reply-To: <80e0215a-cd00-57f9-afb6-b85b33dba91d@gmail.com>

Bagas Sanjaya wrote:
> Let's say that we had consented that my patch series was deemed ready at
> v5 version. From the paragraph above, I interpreted it as "now my series
> was consented ready, I need to send v6 to Junio (current Git maintainer)".
> In practice, the maintainer could instead merged v5 (without having me to
> send v6 [final]), because v5 is merge-ready in absence of maintainer's
> email address in either To: or Cc:.

Yes and no.

Consensus, mearge-ready status, and merged, are three very diffent
concepts. Generally they are one-and-the-same, but not always.

 1. A patch can have consensus, and yet Junio doesn't merge it
 2. A patch may not have consensus, and yet Junio merges it
 3. A patch may be merge-ready, no consensus, and yet merged
 4. A patch may be merge-ready, no consensus, and unmerged
 ...

I'm not going through every combination... You get the point.


Generally you don't need to worry about this, that's Junio's job. If
your patch is ready, Junio will merge it... But not always.

So no, you don't need to send v6, Junio will pick v5. If he doesn't,
it's most likely because it slipped through the cracks, and you can see
that in the next "What's cooking in git.git".

If you don't see your merge-ready patch series in "what's cooking", then
by all means send it again as v6, or reply to the "what's cooking" or
something. But generally there's no point in sending a v6 identical to a
v5.

Just poke Junio.

> Oh yeah, should mailing list's address be also in To:/Cc: when sending
> merge-ready patch series?

IMO the maxim should be: if it's relevant to git, send it to to the git
mailing list... *Always*... Don't ever hesitate.

But if you already sent a v5 that is is merge-ready, there's no need
to send an identical v6.


All these suggestions are of course based on my own experience. Others
might have different experiences.

Cheers.

-- 
Felipe Contreras

  reply	other threads:[~2021-05-12  6:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  2:54 [PATCH v1] " Dave Huseby
2021-05-12  2:57 ` Dave Huseby
2021-05-12  6:25   ` Felipe Contreras
2021-05-12  3:18 ` Dave Huseby
2021-05-12  3:18   ` [PATCH v2] Writing down mail list etiquette Dave Huseby
2021-05-12  4:07     ` Bagas Sanjaya
2021-05-12  6:45       ` Felipe Contreras [this message]
2021-05-12  7:35         ` Eric Sunshine
2021-05-12  8:32           ` Felipe Contreras
2021-05-12 14:36           ` Junio C Hamano
2021-05-12  4:46     ` Junio C Hamano
2021-05-12  8:45     ` Ævar Arnfjörð Bjarmason
2021-05-12 23:34     ` [PATCH v3] doc: writing down Git mailing " Dave Huseby
2021-05-13  0:20       ` Junio C Hamano
2021-05-13 17:17         ` Dave Huseby
2021-05-13 20:04           ` Felipe Contreras
2021-05-13 21:11           ` Junio C Hamano
2021-05-13  4:06       ` Bagas Sanjaya
2021-05-13  6:34       ` Felipe Contreras
2021-05-13  7:01       ` Bagas Sanjaya
2021-06-09 17:36       ` Felipe Contreras
2021-06-18 20:43         ` Dave Huseby
2021-06-18 23:48           ` Felipe Contreras
2021-05-12 15:28   ` and... Re: [PATCH v1] Writing down mail " Philip Oakley
2021-05-12  6:21 ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=609b797a818bb_6d897208ce@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=dwh@linuxprogrammer.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stefanmoch@mail.de \
    --subject='Re: [PATCH v2] Writing down mail list etiquette.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).