git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>,
	Leah Neukirchen <leah@vuxu.org>
Subject: Re: [PATCH] help: colorize man pages
Date: Fri, 21 May 2021 13:09:06 -0500	[thread overview]
Message-ID: <60a7f7427eab6_55039208ba@natae.notmuch> (raw)
In-Reply-To: <YKcFrbuuJrWAxXgm@camp.crustytoothpaste.net>

brian m. carlson wrote:
> On 2021-05-19 at 08:41:44, Ævar Arnfjörð Bjarmason wrote:
> > It also doesn't seem to me to satisfy their FAQ point #1, i.e. users who
> > actually want no color at all can just set TERM=dumb, and we support
> > that. The proposed patch is the same as having TERM=dumb set.
> > 
> > This NO_COLOR=1 actually means something like "I do support colors, so
> > show them if it's important, but don't color things willy-nilly".
> 
> I don't agree.  The way I read it is that it means that if your program
> receives colored input, it is not obligated to strip it out, but it is
> obligated not to add any.

The very example they give says otherwise:

  It is reasonable to configure certain software such as a text editor
  to use color

They are saying a text editor adding color is *fine*.

> NO_COLOR=1 says, "I don't want color, but I have a fully functional
> terminal I would like to use, thank you."

That's not what it says.

> In other words, I think in this case, the user has opted to configure
> their editor as they like it and invoke it without NO_COLOR, but has
> instructed other programs to not add color with NO_COLOR.

That is a reasonable interpretation... until you read the next
answer:

  A user should be able to export $NO_COLOR in their shell configuration
  file as a default, but configure a specific program in its
  configuration file to specifically enable color.

The whole point is not to configure each program to disable color, but
have a global NO_COLOR.

So I don't think your interpretation is correct.

-- 
Felipe Contreras

  reply	other threads:[~2021-05-21 18:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  1:01 Felipe Contreras
2021-05-18  1:19 ` brian m. carlson
2021-05-18  3:22   ` Felipe Contreras
2021-05-18 23:49     ` brian m. carlson
2021-05-19  1:08       ` Junio C Hamano
2021-05-19  2:07         ` brian m. carlson
2021-05-19  6:09           ` Junio C Hamano
2021-05-19  8:41             ` Ævar Arnfjörð Bjarmason
2021-05-19 10:36               ` Felipe Contreras
2021-05-21  0:58               ` brian m. carlson
2021-05-21 18:09                 ` Felipe Contreras [this message]
2021-05-21 19:48                   ` Igor Djordjevic
2021-05-21 21:20                     ` Felipe Contreras
2021-05-21 22:10                       ` Igor Djordjevic
2021-05-21 23:04                         ` Felipe Contreras
2021-05-22 18:38                           ` Igor Djordjevic
2021-05-22 21:48                             ` Felipe Contreras
2021-05-23 11:25                               ` Igor Djordjevic
2021-05-23 14:48                                 ` Felipe Contreras
2021-05-21 22:47                     ` Igor Djordjevic
2021-05-21 23:32                     ` Junio C Hamano
2021-05-19  9:26       ` Ævar Arnfjörð Bjarmason
2021-05-19 10:10         ` Jeff King
2021-05-19 11:45           ` Felipe Contreras
2021-05-19 11:19         ` Felipe Contreras
2021-05-19 12:21           ` Felipe Contreras
2021-05-20  1:55         ` brian m. carlson
2021-05-20  2:23           ` Junio C Hamano
2021-05-20  3:05             ` Felipe Contreras
2021-05-20  3:28               ` Junio C Hamano
2021-05-20  3:48                 ` Felipe Contreras
2021-05-20  2:45           ` Felipe Contreras
2021-05-19 10:25       ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60a7f7427eab6_55039208ba@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=leah@vuxu.org \
    --cc=rsbecker@nexbridge.com \
    --cc=sandals@crustytoothpaste.net \
    --subject='Re: [PATCH] help: colorize man pages' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).