git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2021, #03; Thu, 20)
Date: Mon, 24 May 2021 11:48:08 -0500	[thread overview]
Message-ID: <60abd8c84afed_1b2092087d@natae.notmuch> (raw)
In-Reply-To: <87lf84o23t.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> On Fri, May 21 2021, Felipe Contreras wrote:
> > Junio C Hamano wrote:
> >> Here are the topics that have been cooking.
> >
> >> --------------------------------------------------
> >> [New Topics]
> >
> > Is this not a topic?
> >
> > 1. doc: asciidoc cleanups
> > https://lore.kernel.org/git/20210514115631.503276-1-felipe.contreras@gmail.com/

> These were sent around the same time as v2.32.0-rc0 went out.

That's v2 (of the first patch). v1 [1] was sent on May 12. The only
difference is that one chunk of code moved from patch #4 to patch #3. It
was good then.

> Junio tends to not pick up new things around the release freeze.

And yet a patch from May 20 had no problem landing [2]. And another one
from you [3] also from May 20.

They both landed on "what's cooking" the very same day. In fact, the
former 11 hours later.

> I've only skimmed those topics but they seem like sensible fixes, I
> think it's probably best to let discussion on them settle/continue,
> and re-roll or re-send sometime after v2.32.0.

Sure, they don't belong on 'master', but the first patch series is ready
for 'next' (and was ready since v2), and even if it wasn't, 'seen' is
for proposed changes that don't qualify for 'next'.

I think this qualifies as a proposed change. In fact, a proposed change
that has been reviewed, it's simple, and could not possibly introduce an
issue (famous last words); more than can be said of many patches in
'seen'.

Either way, I'm just asking what's going on.

Cheers.

[1] https://lore.kernel.org/git/20210512222803.508446-1-felipe.contreras@gmail.com/
[2] https://lore.kernel.org/git/20210520210546.4129620-1-emilyshaffer@google.com/
[3] https://lore.kernel.org/git/cover-00.17-0000000000-20210520T111610Z-avarab@gmail.com/

-- 
Felipe Contreras

      reply	other threads:[~2021-05-24 16:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  3:26 Junio C Hamano
2021-05-20  8:18 ` Elijah Newren
2021-05-20 22:43   ` Junio C Hamano
2021-05-20 11:25 ` Ævar Arnfjörð Bjarmason
2021-05-21 22:33 ` Felipe Contreras
2021-05-24 10:29   ` Ævar Arnfjörð Bjarmason
2021-05-24 16:48     ` Felipe Contreras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60abd8c84afed_1b2092087d@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --subject='Re: What'\''s cooking in git.git (May 2021, #03; Thu, 20)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).