From: Derrick Stolee <stolee@gmail.com>
To: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Cc: peff@peff.net, dstolee@microsoft.com, gitster@pobox.com
Subject: Re: [PATCH] builtin/repack.c: set a default factor for '--geometric'
Date: Tue, 20 Apr 2021 08:39:33 -0400 [thread overview]
Message-ID: <60af51b7-b2a3-8acf-f7a0-49a137daf2c6@gmail.com> (raw)
In-Reply-To: <1ecab817396fae6a1cbafde1ca8b3ebfd9ae4c11.1618883241.git.me@ttaylorr.com>
On 4/19/2021 9:47 PM, Taylor Blau wrote:
> The '--geometric=<n>' argument specifies that each pack must contain at
> least 'n' times as many objects as the size of the next-largest pack.
> The factor 'n' is customizable, but setting it to '2' is a sane default.
>
> Instead of making the factor a required argument, make the argument
> optional with a default value of '2'.
This flexibility is nice.
> To ensure that the option is setup correctly, modify the most complex
> test of t7703 to drop the explicit factor.
Good testing.
> --g=<factor>::
> ---geometric=<factor>::
> +-g=[<factor>]::
> +--geometric[=<factor>]::
> Arrange resulting pack structure so that each successive pack
> - contains at least `<factor>` times the number of objects as the
> - next-largest pack.
> + contains at least `<factor>` (`2` if unspecified) times the
> + number of objects as the next-largest pack.
The parenthetical interrupts what `<factor>` means. Perhaps
rearrange:
Arrange resulting pack structure so that each successive pack
contains at least `<factor>` times the number of objects as the
next-largest pack. If `<factor>` is not specified, then `2` is
used by default.
Rest of the diff looks good.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-04-20 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 1:47 [PATCH] builtin/repack.c: set a default factor for '--geometric' Taylor Blau
2021-04-20 12:39 ` Derrick Stolee [this message]
2021-04-20 20:25 ` Junio C Hamano
2021-04-20 20:31 ` Taylor Blau
2021-04-20 20:32 ` [PATCH v2] " Taylor Blau
2021-04-20 21:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60af51b7-b2a3-8acf-f7a0-49a137daf2c6@gmail.com \
--to=stolee@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).