From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>, Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>,
"Sergey Organov" <sorganov@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] xdiff: implement a zealous diff3
Date: Mon, 14 Jun 2021 23:19:46 -0500 [thread overview]
Message-ID: <60c82a622ae66_e5292087f@natae.notmuch> (raw)
In-Reply-To: <YMbexfeUG78yBix4@coredump.intra.peff.net>
Jeff King wrote:
> On Sun, Jun 13, 2021 at 01:00:33PM -0500, Felipe Contreras wrote:
>
> > > > I'm re-sending this patch from 2013 because I do think it provides value
> > > > and we might want to make it the default.
> > >
> > > I take it you didn't investigate the segfault I mentioned.
> >
> > I don't know how I was supposed to investigate the few segfaults you
> > mentioned. All you said is that you never tracked the bug.
>
> My point is that if you are going to repost a patch that has known
> problems,
It was not known that it had problems.
That fact that person X said patch Y had a problem doesn't necessarily
mean that patch Y has a problem.
1. The problem in the past might not apply in the present
2. The problem X person had might be specific to his/her setup
3. The problem might be due a combination of patches, not the patch
itself
Plus many others.
A logical person sees evidence for what it is, and the only thing that
person X saying patch Y had a problem means, is that person X said patch
Y had a problem.
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-15 4:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 14:31 [PATCH] xdiff: implement a zealous diff3 Felipe Contreras
2021-06-13 15:42 ` Jeff King
2021-06-13 18:00 ` Felipe Contreras
2021-06-13 21:24 ` Felipe Contreras
2021-06-15 2:07 ` Junio C Hamano
2021-06-15 3:43 ` Elijah Newren
2021-06-15 4:03 ` Junio C Hamano
2021-06-15 9:20 ` Felipe Contreras
2021-06-15 9:16 ` Felipe Contreras
2021-06-15 16:59 ` Elijah Newren
2021-06-14 4:44 ` Jeff King
2021-06-15 4:19 ` Felipe Contreras [this message]
2021-06-15 9:24 ` Jeff King
2021-06-15 10:24 ` Felipe Contreras
-- strict thread matches above, loose matches on Subject: below --
2013-03-06 20:03 feature suggestion: optimize common parts for checkout --conflict=diff3 Jeff King
2013-03-06 20:36 ` [PATCH] xdiff: implement a zealous diff3 Uwe Kleine-König
2013-03-06 20:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60c82a622ae66_e5292087f@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sorganov@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).