git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Elijah Newren <newren@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Philip Oakley <philipoakley@iee.email>,
	Alex Henrie <alexhenrie24@gmail.com>, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/3] pull: obvious fixes
Date: Tue, 15 Jun 2021 05:41:09 -0500	[thread overview]
Message-ID: <60c883c5baf07_e63320830@natae.notmuch> (raw)
In-Reply-To: <CABPp-BFEc2aQV_kTTiDh3WV5oBwr4tOzO6LOGnMAHudZdXVo6Q@mail.gmail.com>

Elijah Newren wrote:
> On Sat, Jun 12, 2021 at 9:59 PM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > These are obvious fixes that I sent many times in series like [1], but
> > for some reason they were never merged.
> >
> > There's absolutely no reason not to merge these.
> >
> > [1] https://lore.kernel.org/git/20201218211026.1937168-1-felipe.contreras@gmail.com/
> 
> I was really surprised to see the Reviewed-by on patch 1, and did not
> remember what review I had done.  Unfortunately, since your new patch
> series aren't posted as responses to old ones (see
> https://lore.kernel.org/git/CABPp-BEEiPP7AEk4Wexw4_MDHcin2n8xkMowO=OXTn9pNPaG0A@mail.gmail.com/T/#u
> for an example of what I mean), and since the cover letter you linked
> to didn't reference previous series,

But my cover letter did reference a previous series:

  https://lore.kernel.org/git/20201218211026.1937168-1-felipe.contreras@gmail.com/

See patch 3, 4, and 5.

The problem is that these patches (along with many others) were part of
different series, that I reordered, split, and joined in order to make it
clear why all of them were needed. When I split them people didn't
understand the context, and when I joined them, suddenly there were too
many.

> there's no trace of where it came from.  I had to go digging to try to
> find it.  Any chance you could tweak your posts in the future to help
> reviewers follow how things have evolved?

I always do that, including this series.

In order to properly dig through all the versions of these particualr 3
patches it would probably take me an hour, and I don't know how much
value that would provide. I just picked the latest one I could find that
contained them.

-- 
Felipe Contreras

  parent reply	other threads:[~2021-06-15 10:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13  4:59 [PATCH 0/3] pull: obvious fixes Felipe Contreras
2021-06-13  4:59 ` [PATCH 1/3] pull: cleanup autostash check Felipe Contreras
2021-06-14 14:56   ` Elijah Newren
2021-06-15 10:59     ` Felipe Contreras
     [not found]   ` <CAPUEspg_MmerWb7h8MyhgcJXbWrJeeSyeJ7z2S6eHgDfRDPKvA@mail.gmail.com>
2021-06-15 11:09     ` Felipe Contreras
2021-06-13  4:59 ` [PATCH 2/3] pull: trivial cleanup Felipe Contreras
2021-06-14 14:57   ` Elijah Newren
2021-06-13  4:59 ` [PATCH 3/3] pull: trivial whitespace style fix Felipe Contreras
2021-06-14 15:03   ` Elijah Newren
2021-06-14 14:47 ` [PATCH 0/3] pull: obvious fixes Elijah Newren
2021-06-15  1:25   ` Junio C Hamano
2021-06-15 10:41   ` Felipe Contreras [this message]
2021-06-17 16:17 ` [PATCH v2 " Felipe Contreras
2021-06-17 16:17   ` [PATCH v2 1/3] pull: cleanup autostash check Felipe Contreras
2021-06-17 16:17   ` [PATCH v2 2/3] pull: trivial cleanup Felipe Contreras
2021-06-17 16:17   ` [PATCH v2 3/3] pull: trivial whitespace style fix Felipe Contreras
2021-06-17 16:48   ` [PATCH v2 0/3] pull: obvious fixes Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60c883c5baf07_e63320830@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=alexhenrie24@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=philipoakley@iee.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).