From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"John Keeping" <john@keeping.me.uk>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] test: fix for TEST_OUTPUT_DIRECTORY
Date: Tue, 15 Jun 2021 12:45:37 -0500 [thread overview]
Message-ID: <60c8e7419b90c_12c282081a@natae.notmuch> (raw)
In-Reply-To: <8735tk22if.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
>
> On Mon, Jun 14 2021, Felipe Contreras wrote:
>
> > Jeff King wrote:
> >> or even making things worse (as this patch did).
> >
> > I think breaking the test suite is objectively worse than having a few
> > extra files in the output directory, but to each his own.
>
> We've got both in-tree and out-tree things that rely on e.g. the
> *.counts in that directory to have a 1=1 mapping with "real"
> tests. E.g. "make aggregate-results".
Yeah, that's not good, but I wouldn't call it "worse".
> >> I don't know if anybody still uses it these days, though. I suspect it's
> >> outlived its usefulness, in that we would typically not have any
> >> valgrind errors at all (so coalescing them is not that interesting).
> >>
> >> Possibly folks investigating leak-checking via valgrind could find it
> >> useful, but even there I think LSan is a much better path forward.
> >
> > Yeah, but even if they do run this tool, they can set
> > TEST_OUTPUT_DIRECTORY manually.
> >
> > The needs of the few should not otweight needs of the many.
>
> Do we need to bring Spock into this?:)
Hopefully not.
> I think the following alternate/on-top patch (which you should feel free
> to squash in with my SOB if you agree) solves the issue both of you are
> noting.
>
> It will barf if you run the tests under e.g. --tee with that environment
> variable, but that's intentional. It's better to loudly error if we
> don't have the expected test-results than to silently write in the wrong
> place.
I'm not sure how that patch was supposed to work:
'err' is not empty, it contains:
mkdir: cannot create directory '/dev/null': File exists
/home/felipec/dev/git.git/git/t/test-lib.sh: line 1133: /dev/null.counts: Permission denied
not ok 5 - pretend we have a fully passing test suite
Does this assume the rest of the framework will be updated to properly
handle TEST_NO_RESULTS_OUTPUT?
Cheers.
--
Felipe Contreras
prev parent reply other threads:[~2021-06-15 17:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 17:05 [PATCH] test: fix for TEST_OUTPUT_DIRECTORY Felipe Contreras
2021-06-13 4:42 ` Jeff King
2021-06-13 15:44 ` Felipe Contreras
2021-06-14 7:43 ` Jeff King
2021-06-14 8:39 ` Felipe Contreras
2021-06-14 9:33 ` Ævar Arnfjörð Bjarmason
2021-06-14 14:25 ` Jeff King
2021-06-14 16:55 ` Ævar Arnfjörð Bjarmason
2021-06-15 11:10 ` Jeff King
2021-06-15 11:21 ` Bagas Sanjaya
2021-06-15 11:23 ` Jeff King
2021-06-15 18:09 ` Felipe Contreras
2021-06-15 17:45 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60c8e7419b90c_12c282081a@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).