From: Felipe Contreras <felipe.contreras@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2021, #06; Thu, 17)
Date: Thu, 17 Jun 2021 23:20:11 -0500 [thread overview]
Message-ID: <60cc1efb4f691_5d7b82086d@natae.notmuch> (raw)
In-Reply-To: <YMvhoXVBoO08ziI1@camp.crustytoothpaste.net>
brian m. carlson wrote:
> On 2021-06-17 at 02:55:26, Junio C Hamano wrote:
> > * bc/doc-asciidoctor-to-man-wo-xmlto (2021-05-14) 2 commits
> > - doc: remove GNU_ROFF option
> > - doc: add an option to have Asciidoctor build man pages directly
> >
> > An option to render the manual pages via AsciiDoctor bypassing
> > xmlto has been introduced.
> >
> > What is the status of this one?
>
> Probably best to drop it.
> I think Felipe didn't want his sign-off on it, and I don't think
> there's a good way to produce an equivalent patch without
> incorporating his changes.
I explained very clearly what I would expect to happen for this patch to
be valid [1]; you don't need to drop the patch, simply state that *you*
wrote the commit message, not me.
Here, I'm copying *exactly* what I wrote so there's no confusion:
Hard to tell in this frankenstein commit. I'd be fine with a
Commit-message-by line.
> We don't seem to see eye to eye on an appropriate solution to the
> problem, and I don't feel like arguing about it further.
I don't see what is the big problem. I said you should split your patch
into multiple patches, since I believe your patch is doing multiple
unlrelated changes at once.
In fact, your patches don't not apply to master anymore (since you made too
many changes), while my patch series [2] does apply cleanly.
I don't mind our competening series to hash it out again, but first you
need to send another round which does applie cleanly on top of
master--unlike your previous one. And then I'd comment my objections to
it, yet again.
Cheers.
[1] https://lore.kernel.org/git/609b5c85b7c61_678ff20848@natae.notmuch/
[2] https://lore.kernel.org/git/20210608090026.1737348-1-felipe.contreras@gmail.com/
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-18 4:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 2:55 What's cooking in git.git (Jun 2021, #06; Thu, 17) Junio C Hamano
2021-06-17 9:38 ` jh/builtin-fsmonitor, was " Johannes Schindelin
2021-06-17 9:40 ` js/subtree-on-windows-fix, " Johannes Schindelin
2021-06-17 12:38 ` Contributions which I feel are dangerous and/or deceptive (Was: Re: What's cooking in git.git (Jun 2021, #06; Thu, 17)) Elijah Newren
2021-06-17 14:19 ` Felipe Contreras
2021-06-17 15:06 ` Elijah Newren
2021-06-17 16:58 ` Felipe Contreras
2021-06-17 14:42 ` What's cooking in git.git (Jun 2021, #06; Thu, 17) Felipe Contreras
2021-06-17 23:58 ` brian m. carlson
2021-06-18 0:27 ` Jeff King
2021-06-18 4:28 ` Felipe Contreras
2021-06-19 7:18 ` Junio C Hamano
2021-06-19 17:27 ` Ignoring valid work Felipe Contreras
2021-06-18 4:20 ` Felipe Contreras [this message]
2021-06-18 16:32 ` What's cooking in git.git (Jun 2021, #06; Thu, 17) Jeff Hostetler
2021-06-25 22:21 ` Emily Shaffer
2021-06-25 22:26 ` Randall S. Becker
2021-06-28 16:46 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60cc1efb4f691_5d7b82086d@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).