From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Hu Jialun <hujialun@comp.nus.edu.sg>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: remove irrelavent prompt on `--allow-empty-message`
Date: Tue, 06 Jul 2021 23:37:40 -0500 [thread overview]
Message-ID: <60e52f945507_2fe63d2088c@natae.notmuch> (raw)
In-Reply-To: <xmqqlf6jla5o.fsf@gitster.g>
Junio C Hamano wrote:
> Hu Jialun <hujialun@comp.nus.edu.sg> writes:
>
> > Currently, COMMIT_EDITMSG contains "...and an empty message aborts the
> > commit", regardless of whether the --allow-empty-message option is
> > specified or not. This is deemed confusing and unintended.
>
> I have to wonder what reason a user have to use that option, other
> than wanting to record a commit without any message. In other words,
> wouldn't it be a bug for this command
>
> $ git commit --allow-empty-message
>
> to open an editor to allow editing the message, instead of just
> committing with an empty message?
To translate this question into more programmatical terms.
Should this commit an empty message?
% git commit --allow-empty-message -m "$msg"
I say the answer is no.
We need to know what the message is.
--
Felipe Contreras
next prev parent reply other threads:[~2021-07-07 4:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 2:24 [PATCH] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-06 15:44 ` Junio C Hamano
2021-07-07 4:37 ` Felipe Contreras [this message]
2021-07-07 10:43 ` Hu Jialun
2021-07-07 16:23 ` Hu Jialun
2021-07-07 16:23 ` [PATCH v2 1/2] commit: reorganise duplicate commit prompt strings Hu Jialun
2021-07-07 16:57 ` Đoàn Trần Công Danh
2021-07-07 17:44 ` Junio C Hamano
2021-07-07 16:23 ` [PATCH v2 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-07 17:42 ` Felipe Contreras
2021-07-08 15:19 ` [PATCH] " Hu Jialun
2021-07-08 16:05 ` Đoàn Trần Công Danh
2021-07-08 18:26 ` Junio C Hamano
2021-07-09 18:07 ` [PATCH v3 1/2] commit: reorganise commit hint strings Hu Jialun
2021-07-09 19:14 ` Junio C Hamano
2021-07-09 18:07 ` [PATCH v3 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-09 19:14 ` Junio C Hamano
2021-07-10 17:26 ` Hu Jialun
2021-07-22 18:33 ` Hu Jialun
2021-07-22 21:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e52f945507_2fe63d2088c@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hujialun@comp.nus.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).