From: Luben Tuikov <firstname.lastname@example.org>
To: Junio C Hamano <email@example.com>,
Michael Strawbridge <firstname.lastname@example.org>
Cc: email@example.com, "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org>
Subject: Re: [PATCH v9 2/2] send-email: expose header information to git-send-email's sendemail-validate hook
Date: Wed, 19 Apr 2023 14:05:09 -0400 [thread overview]
Message-ID: <email@example.com> (raw)
On 2023-04-19 13:01, Junio C Hamano wrote:
> Michael Strawbridge <firstname.lastname@example.org> writes:
>>>> +Below is an example for a few common headers. Take notice of the
>>> "example of" not "for".
>>> This maybe clearer:
>>> "An example of a few common headers is shown below. Take notice ..."
>>>> +test_expect_success $PREREQ "--validate hook supports header argument" '
>>>> + write_script my-hooks/sendemail-validate <<-\EOF &&
>>>> + if test "$#" -ge 2
>>>> + then
>>> There appears to be an extra indentation of the "if" statement.
>> Good catch. It was a matter of spaces and tabs combining that wasn't
>> easy to see.
> I was reading the list of stalled topics in the periodical "What's
> cooking" report and noticed that this topic has been marked as
> "Expecting a hopefully minor and final reroll." for full three
> months after we saw this message. Should we be waiting more?
Thanks Junio for the reminder--I was wondering the same thing not
so long ago.
We'll re-roll it and submit it for inclusion.
next prev parent reply other threads:[~2023-04-19 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 1:24 [PATCH v9 0/2] send-email: expose header information to git-send-email's sendemail-validate hook Michael Strawbridge
2023-01-20 1:24 ` [PATCH v9 1/2] send-email: refactor header generation functions Michael Strawbridge
2023-01-20 1:24 ` [PATCH v9 2/2] send-email: expose header information to git-send-email's sendemail-validate hook Michael Strawbridge
2023-01-20 13:07 ` Luben Tuikov
2023-01-20 14:25 ` Michael Strawbridge
2023-04-19 17:01 ` Junio C Hamano
2023-04-19 18:05 ` Luben Tuikov [this message]
2023-01-23 13:51 ` [PATCH v9 0/2] " Ævar Arnfjörð Bjarmason
2023-01-23 16:03 ` Michael Strawbridge
2023-01-30 10:40 ` Ævar Arnfjörð Bjarmason
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).