From: Jack Bates <bk874k@nottheoilrig.com>
To: eroen <git-scm@occam.eroen.eu>, git@vger.kernel.org
Subject: Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API
Date: Thu, 12 Jan 2017 09:55:02 -0700 [thread overview]
Message-ID: <66967e0e-8bd9-f4b6-d2d4-ccce9004f42e@nottheoilrig.com> (raw)
In-Reply-To: <20170112104219.563497-1-git-scm@occam.eroen.eu>
You might need the following, to still build with LibreSSL.
That was my experience anyway, when I recently prepared similar fixes
for OpenSSL 1.1 and Apache Traffic Server.
#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)
On 12/01/17 03:42 AM, eroen wrote:
> Library initialization functions are deprecated in openssl 1.1.0 API, as
> initialization is handled by openssl internally.
>
> Symbols for deprecated functions are not exported if openssl is built with
> `--api=1.1 disable-deprecated`, so their use will cause a build failure.
>
> Reported-by: Lars Wendler (Polynomial-C)
>
> X-Gentoo-Bug: 592466
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
> ---
> imap-send.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index 5c7e27a89..98774360e 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
> int ret;
> X509 *cert;
>
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
> SSL_library_init();
> SSL_load_error_strings();
> +#endif
>
> meth = SSLv23_method();
> if (!meth) {
>
prev parent reply other threads:[~2017-01-12 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 10:42 [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API eroen
2017-01-12 16:53 ` Jack Bates
2017-01-12 16:55 ` Jack Bates [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66967e0e-8bd9-f4b6-d2d4-ccce9004f42e@nottheoilrig.com \
--to=bk874k@nottheoilrig.com \
--cc=git-scm@occam.eroen.eu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).