Re: [PATCH v3 09/11] bundle-uri: allow relative URLs in bundle lists

[Derrick Stolee <derrickstolee@github.com>]

On 12/5/2022 6:33 PM, Victoria Dye wrote:
> Derrick Stolee via GitGitGadget wrote:
>> Allow a bundle list to specify a relative URI for the bundles. This URI
>> is based on where the client received the bundle list. For a list
>> provided in the 'bundle-uri' protocol v2 command, the Git remote URI is
>> the base URI. Otherwise, the bundle list was provided from an HTTP URI
>> not using the Git protocol, and that URI is the base URI. This allows
>> easier distribution of bundle data.
> 
> Thanks, this clears up my confusion about the source of 'baseURI'.
> 
>> +	/**
>> +	 * The baseURI of a bundle_list is the URI that provided the list.
>> +	 *
>> +	 * In the case of the 'bundle-uri' protocol v2 command, the base
>> +	 * URI is the URI of the Git remote.
>> +	 *
>> +	 * Otherewise, the bundle list was downloaded over HTTP from some
>> +	 * known URI.
> 
> s/Otherewise/Otherwise
> 
> Also, this sentence is a bit more vague than what was noted in the commit
> message; it doesn't actually say what the base URI is set to in this
> scenario. Feel free to ignore if you think it's overkill, but that could
> probably be cleared up by adding another sentence after like "The base URI
> is set to that known URI."

Thanks for both of these suggestions.

-Stolee