From: Jeff Hostetler <git@jeffhostetler.com>
To: Josh Steadmon <steadmon@google.com>, git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH v2] fetch-pack: add tracing for negotiation rounds
Date: Mon, 15 Aug 2022 11:08:24 -0400 [thread overview]
Message-ID: <7dae2e8b-1168-3738-8efb-7ecfdfae796a@jeffhostetler.com> (raw)
In-Reply-To: <4390677ec75d51487142adf7c2ab821cbd24a53e.1659477669.git.steadmon@google.com>
On 8/2/22 6:04 PM, Josh Steadmon wrote:
> Currently, negotiation for V0/V1/V2 fetch have trace2 regions covering
> the entire negotiation process. However, we'd like additional data, such
> as timing for each round of negotiation or the number of "haves" in each
> round. Additionally, "independent negotiation" (AKA push negotiation)
> has no tracing at all. Having this data would allow us to compare the
> performance of the various negotation implementations, and to debug
> unexpectedly slow fetch & push sessions.
>
> Add per-round trace2 regions for all negotiation implementations (V0+V1,
> V2, and independent negotiation), as well as an overall region for
> independent negotiation. Add trace2 data logging for the number of haves
> and "in vain" objects for each round, and for the total number of rounds
> once negotiation completes. Finally, add a few checks into various
> tests to verify that the number of rounds is logged as expected.
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
Sorry for the delay in responding. Just got back from a much
needed vacation.
This version LGTM.
Thanks
Jeff
prev parent reply other threads:[~2022-08-15 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 22:13 [PATCH] fetch-pack: add tracing for negotiation rounds Josh Steadmon
2022-07-25 23:07 ` Junio C Hamano
2022-08-02 21:51 ` Josh Steadmon
2022-07-26 0:04 ` Jeff Hostetler
2022-08-02 21:52 ` Josh Steadmon
2022-08-02 22:04 ` [PATCH v2] " Josh Steadmon
2022-08-15 15:08 ` Jeff Hostetler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dae2e8b-1168-3738-8efb-7ecfdfae796a@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).