Re: [PATCH] notes: do not accept non-blobs as new notes

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] notes: do not accept non-blobs as new notes
Date: Wed, 09 May 2012 10:52:56 -0700	[thread overview]
Message-ID: <7v4nrptf5z.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120509173701.GB30487@sigill.intra.peff.net> (Jeff King's message of "Wed, 9 May 2012 13:37:01 -0400")

Jeff King <peff@peff.net> writes:

> Hmm. I was thinking that we supported arbitrary sha1s as note values via
> the command-line interface. But we don't; that is only the internal C
> API, and it is quite difficult to do anything useful with non-blob notes
> via the command-line interface. As you noticed, you can trick it into
> doing so with "-C", but even "-c" has disastrous results (unless you
> like dumping the binary tree object into your editor).

It is fair to restrict anything that involves an editor or end user
interaction with the terminal output for sanity, and raw tree object data
is on the other side of the border line that defines what is sane, so I
wouldn't have much problem with a new restriction on the command line
interface, except for "-C".  Advertising that we store arbitrary binary
out of an existing blob as-is and then starting to refuse taking it sounds
like a non-starter.