From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
duperrav@minatec.inpg.fr,
Valentin Duperray <Valentin.Duperray@ensimag.imag.fr>,
git@vger.kernel.org, Franck Jonas <Franck.Jonas@ensimag.imag.fr>,
Lucien Kong <Lucien.Kong@ensimag.imag.fr>,
Thomas Nguy <Thomas.Nguy@ensimag.imag.fr>,
Huynh Khoi Nguyen Nguyen
<Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>, Peff <peff@peff.net>
Subject: Re: [PATCHv2] git bisect old/new
Date: Fri, 15 Jun 2012 14:06:30 -0700 [thread overview]
Message-ID: <7v62as9tex.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CABURp0qGUvjtOBp8vQ4LqWsWp-5oi+-2GwVq-edQbUnKzXHR-A@mail.gmail.com> (Phil Hord's message of "Fri, 15 Jun 2012 16:20:51 -0400")
Phil Hord <phil.hord@gmail.com> writes:
> Except that most of the work to support <arbitrary1/arbitrary2> is
> already being done in this patch to add <new/old>, but it will need
> re-doing or un-doing to move to arbitrary terms. Supporting arbitrary
> terms today would save work (the re-doing and the un-doring), if we
> went that way in the future.
You are forgetting that "somebody wrote the code" does not matter
much. What counds more is that the code is more complex than
necessary to support the case we are immediately interested in,
which means it is much more likely to have undiscovered bugs and
will take more effort to update if we need to change the aspects
other than "arbitrary two tokens" later. "Somebody wrote the code
already" matters only when we are sure that we want to build on top
of it. In this case, we don't.
next prev parent reply other threads:[~2012-06-15 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 2:03 [PATCH] git bisect old/new Valentin Duperray
2012-06-12 5:25 ` Christian Couder
2012-06-12 5:43 ` Junio C Hamano
2012-06-12 19:41 ` Phil Hord
2012-06-13 10:12 ` Christian Couder
2012-06-13 17:30 ` Junio C Hamano
2012-06-12 22:56 ` [PATCHv2] " Valentin Duperray
2012-06-12 23:54 ` Junio C Hamano
2012-06-13 18:06 ` duperrav
2012-06-14 9:56 ` Christian Couder
2012-06-14 17:34 ` Junio C Hamano
2012-06-15 20:20 ` Phil Hord
2012-06-15 21:06 ` Junio C Hamano [this message]
2012-06-13 10:05 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62as9tex.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Franck.Jonas@ensimag.imag.fr \
--cc=Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr \
--cc=Lucien.Kong@ensimag.imag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=Thomas.Nguy@ensimag.imag.fr \
--cc=Valentin.Duperray@ensimag.imag.fr \
--cc=christian.couder@gmail.com \
--cc=duperrav@minatec.inpg.fr \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).